[cvs] commit: klutz addlink.php nag addlink.php view.php turba addlink.php whups admin.php create.php details.php search.php klutz/lib api.php horde/lib Links.php api.php nag/lib api.php turba/lib Source.php api.php whups/lib Driver.php api.php ...

Thu Oct 30 20:39:24 PST 2003

chuck       2003/10/30 20:39:24 PST

  Modified files:
    .                    addlink.php 
    .                    addlink.php view.php 
    .                    addlink.php 
    .                    admin.php create.php details.php 
                         search.php 
    lib                  api.php 
    lib                  api.php Links.php 
    lib                  api.php 
    lib                  api.php Source.php 
    lib                  api.php Driver.php 
    config               conf.php.dist 
    templates/addlink    contacts.inc 
    services/links       delete.php 
    templates/links      footer.inc links.inc 
    lib/Driver           prefs.php sql.php 
    lib/Category         sql.php 
    lib/Driver           sql.php 
    templates/addlink    task_summaries.inc 
  Added files:
    scripts              migrate_links.php 
  Removed files:
    lib/Links            sql.php 
  Log:
  Rework the Links driver to use categories instead of a custom sql table,
  from Bo Daley <bo at tilda.com.au>

  Big patch, some things may break/need to be tweaked. Here's Bo's description:

  Attached is a first shot at reworking the Links API to use categories instead of
  its own SQL driver. I haven't yet taken this as far as it can go, but already
  it has resulted in a significant performance improvement for pages in my system
  with large numbers of linked clients. (some of the pages that were previously
  taking 20-30 seconds -- eg. the Whups search page -- are now down to about 5
  seconds, which makes them a bit more usable).

  Things that should be noted before this gets committed:

  * I modified Turba so that the backend's read() function returns an array of
  contact objects rather than just a single object (which speeds up handling of
  large lists of objects). I don't know any ldap so this change will break the
  ldap backend unless someone can make the same change to
  turba/lib/Driver/ldap.php

  * I've included a script (migrate_links.php) that creates links in the new
  structure for people who were using clients in Whups. It doesn't update links
  for other apps that might have been using Links but I can probably add that in
  too if anyone needs it.

  * reverse links don't seem to be working just yet. I'll get onto this soon.

  more soon... hopefully i haven't missed anything else..(!!)

  Revision  Changes    Path
  1.66      +1 -20     horde/config/conf.php.dist
  1.95      +11 -2     horde/lib/Category/sql.php
  1.21      +205 -155  horde/lib/Links.php
  1.13      +0 -240    horde/lib/Links/Attic/sql.php (dead)
  1.23      +2 -6      horde/lib/api.php
  1.1       +90 -0     horde/scripts/migrate_links.php (new)
  1.9       +6 -11     horde/services/links/delete.php
  1.6       +1 -1      horde/templates/links/footer.inc
  1.4       +4 -2      horde/templates/links/links.inc
  1.9       +16 -5     klutz/addlink.php
  1.20      +6 -3      klutz/lib/api.php
  1.7       +26 -8     nag/addlink.php
  1.58      +17 -10    nag/lib/api.php
  1.6       +3 -3      nag/templates/addlink/task_summaries.inc
  1.32      +5 -5      nag/view.php
  1.9       +22 -5     turba/addlink.php
  1.6       +12 -8     turba/lib/Driver/prefs.php
  1.44      +15 -9     turba/lib/Driver/sql.php
  1.77      +46 -20    turba/lib/Source.php
  1.72      +60 -10    turba/lib/api.php
  1.7       +5 -3      turba/templates/addlink/contacts.inc
  1.50      +17 -7     whups/admin.php
  1.42      +11 -11    whups/create.php
  1.60      +5 -3      whups/details.php
  1.76      +105 -96   whups/lib/Driver.php
  1.138     +19 -19    whups/lib/Driver/sql.php
  1.51      +83 -1     whups/lib/api.php
  1.52      +12 -2     whups/search.php

  Chora Links:
  http://cvs.horde.org/diff.php/horde/config/conf.php.dist?r1=1.65&r2=1.66&ty=u
  http://cvs.horde.org/diff.php/horde/lib/Category/sql.php?r1=1.94&r2=1.95&ty=u
  http://cvs.horde.org/diff.php/horde/lib/Links.php?r1=1.20&r2=1.21&ty=u
  http://cvs.horde.org/co.php/horde/lib/Links/Attic/sql.php?r=1.12
  http://cvs.horde.org/diff.php/horde/lib/api.php?r1=1.22&r2=1.23&ty=u
  http://cvs.horde.org/co.php/horde/scripts/migrate_links.php?r=1.1
  http://cvs.horde.org/diff.php/horde/services/links/delete.php?r1=1.8&r2=1.9&ty=u
  http://cvs.horde.org/diff.php/horde/templates/links/footer.inc?r1=1.5&r2=1.6&ty=u
  http://cvs.horde.org/diff.php/horde/templates/links/links.inc?r1=1.3&r2=1.4&ty=u
  http://cvs.horde.org/diff.php/klutz/addlink.php?r1=1.8&r2=1.9&ty=u
  http://cvs.horde.org/diff.php/klutz/lib/api.php?r1=1.19&r2=1.20&ty=u
  http://cvs.horde.org/diff.php/nag/addlink.php?r1=1.6&r2=1.7&ty=u
  http://cvs.horde.org/diff.php/nag/lib/api.php?r1=1.57&r2=1.58&ty=u
  http://cvs.horde.org/diff.php/nag/templates/addlink/task_summaries.inc?r1=1.5&r2=1.6&ty=u
  http://cvs.horde.org/diff.php/nag/view.php?r1=1.31&r2=1.32&ty=u
  http://cvs.horde.org/diff.php/turba/addlink.php?r1=1.8&r2=1.9&ty=u
  http://cvs.horde.org/diff.php/turba/lib/Driver/prefs.php?r1=1.5&r2=1.6&ty=u
  http://cvs.horde.org/diff.php/turba/lib/Driver/sql.php?r1=1.43&r2=1.44&ty=u
  http://cvs.horde.org/diff.php/turba/lib/Source.php?r1=1.76&r2=1.77&ty=u
  http://cvs.horde.org/diff.php/turba/lib/api.php?r1=1.71&r2=1.72&ty=u
  http://cvs.horde.org/diff.php/turba/templates/addlink/contacts.inc?r1=1.6&r2=1.7&ty=u
  http://cvs.horde.org/diff.php/whups/admin.php?r1=1.49&r2=1.50&ty=u
  http://cvs.horde.org/diff.php/whups/create.php?r1=1.41&r2=1.42&ty=u
  http://cvs.horde.org/diff.php/whups/details.php?r1=1.59&r2=1.60&ty=u
  http://cvs.horde.org/diff.php/whups/lib/Driver.php?r1=1.75&r2=1.76&ty=u
  http://cvs.horde.org/diff.php/whups/lib/Driver/sql.php?r1=1.137&r2=1.138&ty=u
  http://cvs.horde.org/diff.php/whups/lib/api.php?r1=1.50&r2=1.51&ty=u
  http://cvs.horde.org/diff.php/whups/search.php?r1=1.51&r2=1.52&ty=u