[cvs] commit: vacation/lib Driver.php vacation/lib/Driver ldap.php
vacation main.php
Chuck Hagenbuch
chuck at horde.org
Fri Dec 19 12:34:28 PST 2003
chuck 2003/12/19 12:34:28 PST
Modified files:
lib Driver.php
lib/Driver ldap.php
. main.php
Log:
Changes:
lib/Driver.php:
- isEnabled() returns 'Y', 'N' or null. This means that if the backend can
say with certainty that vacation is enabled/disabled, the fact can be
reported to the user. If the backend is not so reliable, the functionality
is the same as before.
main.php:
- Make use of the new form of isEnabled().
lib/Driver/ldap.php:
- Added more detailed comments at the top of the file, explaining each
option.
- Fixed a typo :)
- Renamed some functions (eg get_ -> get) to fit the naming convention of
the other drivers
- Added a 'version' parameter - PHP4 defaults to LDAP protocol 2, but newer
versions of OpenLDAP default to protocol 3, so it is necessary to set the
appropriate option befor calling ldap_bind().
... with a few more cleanups from Chuck. The rest of the patch is from Richard.Heggs at nottinghamcity.gov.uk.
Revision Changes Path
1.20 +5 -2 vacation/lib/Driver.php
1.3 +75 -52 vacation/lib/Driver/ldap.php
1.36 +11 -6 vacation/main.php
Chora Links:
http://cvs.horde.org/diff.php/vacation/lib/Driver.php?r1=1.19&r2=1.20&ty=u
http://cvs.horde.org/diff.php/vacation/lib/Driver/ldap.php?r1=1.2&r2=1.3&ty=u
http://cvs.horde.org/diff.php/vacation/main.php?r1=1.35&r2=1.36&ty=u
More information about the cvs
mailing list