[cvs] commit: horde login.php framework/Auth Auth.php gollem redirect.php gollem/lib Gollem.php imp login.php redirect.php imp/lib IMP.php horde/lib Horde.php mimp login.php rakim/guest index.php

[Michael M Slusarz]

slusarz     2004/01/28 11:28:12 PST

  Modified files:
    .                    login.php 
    Auth                 Auth.php 
    .                    redirect.php 
    lib                  Gollem.php 
    .                    login.php redirect.php 
    lib                  IMP.php 
    lib                  Horde.php 
    .                    login.php 
    guest                index.php 
  Log:
  Store authentication error reason/messages in a global array ($__autherrors).
  This is a bit messy but necessary since we a) use Auth:: both statically and
  via objects all over the place so there is no guarantee that
  storing something in an object/static variable will be able to be accessed
  elsewhere, and b) since we use Horde::authenticationErrorRedirect() to redirect
  on most authentication problems (like session timeouts), or our logout
  redirects are disjointed in code a long way from the actual authentication
  failures, it starts to get really messy if we were to start explicitly
  explicitly passing around specific Auth object variables all over the place.
  This change has the additional benefit of allowing us to call
  Auth::addLogoutParameters() with just the URL argument and having that
  function automatically generate the correct parameters necessary to output
  the error message on the login page. That function will still allow a
  specific reason to be passed in if the calling code knows exactly what kind
  of error it wants to throw.
  
  Revision  Changes    Path
  1.115     +32 -45    framework/Auth/Auth.php
  1.113     +13 -14    gollem/lib/Gollem.php
  1.32      +4 -4      gollem/redirect.php
  1.372     +3 -2      horde/lib/Horde.php
  2.151     +2 -2      horde/login.php
  1.414     +4 -4      imp/lib/IMP.php
  2.202     +2 -2      imp/login.php
  1.95      +3 -4      imp/redirect.php
  1.17      +2 -2      mimp/login.php
  1.18      +2 -2      rakim/guest/index.php

  Chora Links:
  http://cvs.horde.org/diff.php/framework/Auth/Auth.php?r1=1.114&r2=1.115&ty=u
  http://cvs.horde.org/diff.php/gollem/lib/Gollem.php?r1=1.112&r2=1.113&ty=u
  http://cvs.horde.org/diff.php/gollem/redirect.php?r1=1.31&r2=1.32&ty=u
  http://cvs.horde.org/diff.php/horde/lib/Horde.php?r1=1.371&r2=1.372&ty=u
  http://cvs.horde.org/diff.php/horde/login.php?r1=2.150&r2=2.151&ty=u
  http://cvs.horde.org/diff.php/imp/lib/IMP.php?r1=1.413&r2=1.414&ty=u
  http://cvs.horde.org/diff.php/imp/login.php?r1=2.201&r2=2.202&ty=u
  http://cvs.horde.org/diff.php/imp/redirect.php?r1=1.94&r2=1.95&ty=u
  http://cvs.horde.org/diff.php/mimp/login.php?r1=1.16&r2=1.17&ty=u
  http://cvs.horde.org/diff.php/rakim/guest/index.php?r1=1.17&r2=1.18&ty=u