[cvs] commit: framework/IMAP/IMAP Tree.php

[Chuck Hagenbuch]

chuck       2004-11-05 10:41:13 PST

  Modified files:
    IMAP/IMAP            Tree.php 
  Log:
  There was a backwards comparison in _childrenInfo() that was causing
  problems for me because it was always fetching the 2nd level of the
  tree. 3rd-level folders wren't being fetched at all, and I think this
  might have been what caused Expand All to go into an infinite loop for
  me.
  
  Also put in a check in _insertElt() to avoid inserting elements with
  empty names. They probably aren't supposed to be there; I was getting
  a blank folder as the first element in each of my non-top-level
  folders.
  
  This fixes my tree menu - including it properly showing all levels,
  which it didn't do before all of this started - and pretty much all of
  the folder issues I was seeing. I'm curious what it does for
  others. If it does fix things, we might try putting some of the string
  functions back unless they really are never necessary.
  
  One hitch is that when I collapse everything only INBOX is shown, not
  my other top-level folders. But I've had enough of this code at the
  moment and can definitely live with that for now. :) Also there seems
  to be duplicate fetching of a bunch of information, but again, I'm not
  up to debugging that just now. It works, and it's decently fast even
  given the redundancy.
  
  Revision  Changes    Path
  1.31      +10 -9     framework/IMAP/IMAP/Tree.php

  Chora Links:
  http://cvs.horde.org/diff.php/framework/IMAP/IMAP/Tree.php?r1=1.30&r2=1.31&ty=u