[cvs] commit: horde/admin groups.php horde/admin/perms addchild.php agora editforum.php forums.php agora/lib Agora.php Forums.php Messages.php api.php agora/lib/Block forums.php thread.php threads.php ansel image.php list.php ansel/lib Ansel.php ...

Tue Dec 7 08:09:18 PST 2004

chuck       2004-12-07 08:09:18 PST

  Modified files:
    admin                groups.php 
    admin/perms          addchild.php 
    .                    editforum.php forums.php 
    lib                  Agora.php api.php Forums.php Messages.php 
    lib/Block            forums.php thread.php threads.php 
    .                    image.php list.php 
    lib                  Ansel.php api.php Gallery.php 
    lib/Block            random_gallery.php random_photo.php 
    scripts/upgrades     2004-01-15_update_gallery_format.php 
                         2004-03-11_touch_galleries.php 
                         2004-05-25_hash_image_paths.php 
                         2004-06-06_store_gallery_ids.php 
                         2004-09-05_add_extensions.php 
    DataTree             DataTree.php package.xml 
    DataTree/DataTree    null.php sql.php 
    Group                Group.php 
    Group/Group          hooks.php 
    History              History.php 
    Relationship/Relationship Manager.php 
    Share                Share.php 
    .                    delete.php pages.php 
    lib                  api.php Bookmarks.php Giapeto.php 
    accounts             index.php 
    books                edit.php index.php 
    invoices             edit.php 
    lib                  Books.php Lists.php 
    lists                accounts.php editaccount.php 
    categories           delete.php edit.php 
    items                index.php 
    lib                  api.php Categories.php 
    lib/Block            categories.php items.php 
    lib/Driver           datatree.php 
    .                    admin.php list.php 
    lib                  Item.php Project.php Thor.php 
    .                    add.php browse.php search.php 
    lib                  Bookmarks.php Trean.php 
    lib/Block            bookmarks.php 
    templates/browse     bookmarks.inc categories.inc 
                         javascript.inc 
  Log:
  Instead of hardcoding '-1' in tons of places, use a new constant: DATATREE_ROOT. Much more readable, etc. At the same time, make this an int (-1) instead of the string value ('-1') which was inconsistent with all other datatree ids, buggy, etc.
  
  Revision  Changes    Path
  1.27      +2 -2      agora/editforum.php
  1.38      +2 -2      agora/forums.php
  1.74      +11 -13    agora/lib/Agora.php
  1.20      +2 -2      agora/lib/Block/forums.php
  1.13      +3 -3      agora/lib/Block/thread.php
  1.38      +3 -3      agora/lib/Block/threads.php
  1.59      +5 -5      agora/lib/Forums.php
  1.108     +5 -5      agora/lib/Messages.php
  1.44      +5 -5      agora/lib/api.php
  1.91      +5 -5      ansel/image.php
  1.92      +5 -5      ansel/lib/Ansel.php
  1.3       +4 -5      ansel/lib/Block/random_gallery.php
  1.5       +5 -6      ansel/lib/Block/random_photo.php
  1.87      +8 -8      ansel/lib/Gallery.php
  1.6       +2 -2      ansel/lib/api.php
  1.56      +3 -3      ansel/list.php
  1.2       +2 -2      ansel/scripts/upgrades/2004-01-15_update_gallery_format.php
  1.2       +2 -2      ansel/scripts/upgrades/2004-03-11_touch_galleries.php
  1.2       +2 -2      ansel/scripts/upgrades/2004-05-25_hash_image_paths.php
  1.2       +2 -2      ansel/scripts/upgrades/2004-06-06_store_gallery_ids.php
  1.3       +2 -2      ansel/scripts/upgrades/2004-09-05_add_extensions.php
  1.151     +39 -34    framework/DataTree/DataTree.php
  1.15      +3 -3      framework/DataTree/DataTree/null.php
  1.156     +14 -14    framework/DataTree/DataTree/sql.php
  1.12      +2 -1      framework/DataTree/package.xml
  1.66      +3 -5      framework/Group/Group.php
  1.7       +1 -2      framework/Group/Group/hooks.php
  1.28      +4 -6      framework/History/History.php
  1.2       +2 -3      framework/Relationship/Relationship/Manager.php
  1.111     +8 -8      framework/Share/Share.php
  1.27      +2 -4      giapeto/delete.php
  1.20      +3 -3      giapeto/lib/Bookmarks.php
  1.202     +5 -6      giapeto/lib/Giapeto.php
  1.12      +4 -5      giapeto/lib/api.php
  1.122     +2 -2      giapeto/pages.php
  1.50      +3 -3      horde/admin/groups.php
  1.27      +3 -3      horde/admin/perms/addchild.php
  1.5       +2 -2      juno/accounts/index.php
  1.19      +2 -2      juno/books/edit.php
  1.14      +2 -2      juno/books/index.php
  1.4       +2 -2      juno/invoices/edit.php
  1.21      +4 -7      juno/lib/Books.php
  1.11      +3 -4      juno/lib/Lists.php
  1.18      +3 -3      juno/lists/accounts.php
  1.18      +2 -2      juno/lists/editaccount.php
  1.16      +2 -2      merk/categories/delete.php
  1.14      +3 -4      merk/categories/edit.php
  1.15      +2 -2      merk/items/index.php
  1.9       +2 -3      merk/lib/Block/categories.php
  1.10      +2 -3      merk/lib/Block/items.php
  1.27      +9 -11     merk/lib/Categories.php
  1.6       +2 -3      merk/lib/api.php
  1.14      +5 -5      nag/lib/Driver/datatree.php
  1.23      +2 -4      thor/admin.php
  1.18      +72 -74    thor/lib/Item.php
  1.40      +11 -11    thor/lib/Project.php
  1.46      +4 -4      thor/lib/Thor.php
  1.33      +2 -2      thor/list.php
  1.24      +3 -3      trean/add.php
  1.32      +6 -6      trean/browse.php
  1.15      +4 -4      trean/lib/Block/bookmarks.php
  1.31      +5 -5      trean/lib/Bookmarks.php
  1.33      +8 -8      trean/lib/Trean.php
  1.12      +2 -2      trean/search.php
  1.18      +1 -1      trean/templates/browse/bookmarks.inc
  1.20      +1 -1      trean/templates/browse/categories.inc
  1.10      +4 -4      trean/templates/browse/javascript.inc

  Chora Links:
  http://cvs.horde.org/diff.php/agora/editforum.php?r1=1.26&r2=1.27&ty=u
  http://cvs.horde.org/diff.php/agora/forums.php?r1=1.37&r2=1.38&ty=u
  http://cvs.horde.org/diff.php/agora/lib/Agora.php?r1=1.73&r2=1.74&ty=u
  http://cvs.horde.org/diff.php/agora/lib/Block/forums.php?r1=1.19&r2=1.20&ty=u
  http://cvs.horde.org/diff.php/agora/lib/Block/thread.php?r1=1.12&r2=1.13&ty=u
  http://cvs.horde.org/diff.php/agora/lib/Block/threads.php?r1=1.37&r2=1.38&ty=u
  http://cvs.horde.org/diff.php/agora/lib/Forums.php?r1=1.58&r2=1.59&ty=u
  http://cvs.horde.org/diff.php/agora/lib/Messages.php?r1=1.107&r2=1.108&ty=u
  http://cvs.horde.org/diff.php/agora/lib/api.php?r1=1.43&r2=1.44&ty=u
  http://cvs.horde.org/diff.php/ansel/image.php?r1=1.90&r2=1.91&ty=u
  http://cvs.horde.org/diff.php/ansel/lib/Ansel.php?r1=1.91&r2=1.92&ty=u
  http://cvs.horde.org/diff.php/ansel/lib/Block/random_gallery.php?r1=1.2&r2=1.3&ty=u
  http://cvs.horde.org/diff.php/ansel/lib/Block/random_photo.php?r1=1.4&r2=1.5&ty=u
  http://cvs.horde.org/diff.php/ansel/lib/Gallery.php?r1=1.86&r2=1.87&ty=u
  http://cvs.horde.org/diff.php/ansel/lib/api.php?r1=1.5&r2=1.6&ty=u
  http://cvs.horde.org/diff.php/ansel/list.php?r1=1.55&r2=1.56&ty=u
  http://cvs.horde.org/diff.php/ansel/scripts/upgrades/2004-01-15_update_gallery_format.php?r1=1.1&r2=1.2&ty=u
  http://cvs.horde.org/diff.php/ansel/scripts/upgrades/2004-03-11_touch_galleries.php?r1=1.1&r2=1.2&ty=u
  http://cvs.horde.org/diff.php/ansel/scripts/upgrades/2004-05-25_hash_image_paths.php?r1=1.1&r2=1.2&ty=u
  http://cvs.horde.org/diff.php/ansel/scripts/upgrades/2004-06-06_store_gallery_ids.php?r1=1.1&r2=1.2&ty=u
  http://cvs.horde.org/diff.php/ansel/scripts/upgrades/2004-09-05_add_extensions.php?r1=1.2&r2=1.3&ty=u
  http://cvs.horde.org/diff.php/framework/DataTree/DataTree.php?r1=1.150&r2=1.151&ty=u
  http://cvs.horde.org/diff.php/framework/DataTree/DataTree/null.php?r1=1.14&r2=1.15&ty=u
  http://cvs.horde.org/diff.php/framework/DataTree/DataTree/sql.php?r1=1.155&r2=1.156&ty=u
  http://cvs.horde.org/diff.php/framework/DataTree/package.xml?r1=1.11&r2=1.12&ty=u
  http://cvs.horde.org/diff.php/framework/Group/Group.php?r1=1.65&r2=1.66&ty=u
  http://cvs.horde.org/diff.php/framework/Group/Group/hooks.php?r1=1.6&r2=1.7&ty=u
  http://cvs.horde.org/diff.php/framework/History/History.php?r1=1.27&r2=1.28&ty=u
  http://cvs.horde.org/diff.php/framework/Relationship/Relationship/Manager.php?r1=1.1&r2=1.2&ty=u
  http://cvs.horde.org/diff.php/framework/Share/Share.php?r1=1.110&r2=1.111&ty=u
  http://cvs.horde.org/diff.php/giapeto/delete.php?r1=1.26&r2=1.27&ty=u
  http://cvs.horde.org/diff.php/giapeto/lib/Bookmarks.php?r1=1.19&r2=1.20&ty=u
  http://cvs.horde.org/diff.php/giapeto/lib/Giapeto.php?r1=1.201&r2=1.202&ty=u
  http://cvs.horde.org/diff.php/giapeto/lib/api.php?r1=1.11&r2=1.12&ty=u
  http://cvs.horde.org/diff.php/giapeto/pages.php?r1=1.121&r2=1.122&ty=u
  http://cvs.horde.org/diff.php/horde/admin/groups.php?r1=1.49&r2=1.50&ty=u
  http://cvs.horde.org/diff.php/horde/admin/perms/addchild.php?r1=1.26&r2=1.27&ty=u
  http://cvs.horde.org/diff.php/juno/accounts/index.php?r1=1.4&r2=1.5&ty=u
  http://cvs.horde.org/diff.php/juno/books/edit.php?r1=1.18&r2=1.19&ty=u
  http://cvs.horde.org/diff.php/juno/books/index.php?r1=1.13&r2=1.14&ty=u
  http://cvs.horde.org/diff.php/juno/invoices/edit.php?r1=1.3&r2=1.4&ty=u
  http://cvs.horde.org/diff.php/juno/lib/Books.php?r1=1.20&r2=1.21&ty=u
  http://cvs.horde.org/diff.php/juno/lib/Lists.php?r1=1.10&r2=1.11&ty=u
  http://cvs.horde.org/diff.php/juno/lists/accounts.php?r1=1.17&r2=1.18&ty=u
  http://cvs.horde.org/diff.php/juno/lists/editaccount.php?r1=1.17&r2=1.18&ty=u
  http://cvs.horde.org/diff.php/merk/categories/delete.php?r1=1.15&r2=1.16&ty=u
  http://cvs.horde.org/diff.php/merk/categories/edit.php?r1=1.13&r2=1.14&ty=u
  http://cvs.horde.org/diff.php/merk/items/index.php?r1=1.14&r2=1.15&ty=u
  http://cvs.horde.org/diff.php/merk/lib/Block/categories.php?r1=1.8&r2=1.9&ty=u
  http://cvs.horde.org/diff.php/merk/lib/Block/items.php?r1=1.9&r2=1.10&ty=u
  http://cvs.horde.org/diff.php/merk/lib/Categories.php?r1=1.26&r2=1.27&ty=u
  http://cvs.horde.org/diff.php/merk/lib/api.php?r1=1.5&r2=1.6&ty=u
  http://cvs.horde.org/diff.php/nag/lib/Driver/datatree.php?r1=1.13&r2=1.14&ty=u
  http://cvs.horde.org/diff.php/thor/admin.php?r1=1.22&r2=1.23&ty=u
  http://cvs.horde.org/diff.php/thor/lib/Item.php?r1=1.17&r2=1.18&ty=u
  http://cvs.horde.org/diff.php/thor/lib/Project.php?r1=1.39&r2=1.40&ty=u
  http://cvs.horde.org/diff.php/thor/lib/Thor.php?r1=1.45&r2=1.46&ty=u
  http://cvs.horde.org/diff.php/thor/list.php?r1=1.32&r2=1.33&ty=u
  http://cvs.horde.org/diff.php/trean/add.php?r1=1.23&r2=1.24&ty=u
  http://cvs.horde.org/diff.php/trean/browse.php?r1=1.31&r2=1.32&ty=u
  http://cvs.horde.org/diff.php/trean/lib/Block/bookmarks.php?r1=1.14&r2=1.15&ty=u
  http://cvs.horde.org/diff.php/trean/lib/Bookmarks.php?r1=1.30&r2=1.31&ty=u
  http://cvs.horde.org/diff.php/trean/lib/Trean.php?r1=1.32&r2=1.33&ty=u
  http://cvs.horde.org/diff.php/trean/search.php?r1=1.11&r2=1.12&ty=u
  http://cvs.horde.org/diff.php/trean/templates/browse/bookmarks.inc?r1=1.17&r2=1.18&ty=u
  http://cvs.horde.org/diff.php/trean/templates/browse/categories.inc?r1=1.19&r2=1.20&ty=u
  http://cvs.horde.org/diff.php/trean/templates/browse/javascript.inc?r1=1.9&r2=1.10&ty=u