[cvs] commit: imp compose.php imp/templates/compose attachments.js compose.inc compose.js

Marko Djukic mdjukic at horde.org
Mon Oct 3 19:08:38 PDT 2005


mdjukic     2005-10-03 19:08:38 PDT

  Modified files:
    .                    compose.php 
    templates/compose    attachments.js compose.inc compose.js 
  Log:
  Code to allow composing to function also without javascript:
  - add a _getActionID() to compose.php which will return actionID if it is already set, eg. through GET type submissions to the script (links) for replies, forwards, etc. otherwise figure out the actionID from the submit button in a form.
  - add support for Tokens to be able to detect accidental multiple submits, warn user if submitted twice and block the second one by resetting to zero the actionID.
  - remove actionID being set in javascript where it is no longer necessary.
  - add a hidden form to compose.inc which will store the token. rename submit buttons to meaningful names so that they can be matched against actionIDs and change the input types to "submit".
  - trim the uniqSubmit() function, now variable hasn't been used for a while. not sure if the remaining js lines are at all needed now, so the whole uniqSubmit() function could be removed entirely?
  
  testing feedback would be good... i've tried a bunch of possibilities, but maybe not hitting them all (js on/off, turning on/off half-way through compose, with/without attachments, cancel, save drafts, rte, etc...)
  
  Revision  Changes    Path
  2.845     +45 -12    imp/compose.php
  2.9       +1 -2      imp/templates/compose/attachments.js
  2.318     +10 -9     imp/templates/compose/compose.inc
  2.22      +0 -14     imp/templates/compose/compose.js

  Chora Links:
  http://cvs.horde.org/diff.php/imp/compose.php?r1=2.844&r2=2.845&ty=u
  http://cvs.horde.org/diff.php/imp/templates/compose/attachments.js?r1=2.8&r2=2.9&ty=u
  http://cvs.horde.org/diff.php/imp/templates/compose/compose.inc?r1=2.317&r2=2.318&ty=u
  http://cvs.horde.org/diff.php/imp/templates/compose/compose.js?r1=2.21&r2=2.22&ty=u


More information about the cvs mailing list