[cvs] commit: scry conclude.php delete.php edit.php editperms.php export.php polls.php view.php vote.php scry/config .cvsignore conf.xml demographics.php.dist hooks.php.dist scry/docs CHANGES CREDITS scry/lib Driver.php Scry.php View.php api.php base.php ...

Sat Nov 24 02:35:27 UTC 2007

duck        2007-11-23 21:35:27 EST

  Modified files:
    .                    conclude.php delete.php edit.php 
                         editperms.php export.php polls.php 
                         view.php vote.php 
    config               .cvsignore conf.xml 
    docs                 CHANGES CREDITS 
    lib                  Driver.php Scry.php api.php base.php 
    lib/Block            poll.php summary.php 
    lib/Driver           sql.php 
    lib/Forms            Vote.php 
    po                   scry.pot sl_SI.po 
    scripts/sql          scry.mssql.sql scry.sql 
    themes               screen.css 
  Added files:
    config               demographics.php.dist hooks.php.dist 
    lib                  View.php 
    scripts/upgrades     2007-11-22_ add_vote_count.php 
                         2007-11-22_ add_vote_count.sql 
                         2007-11-22_ drop_results_to_column.sql 
    templates/block      summary.php 
    templates/main       main.php 
    templates/polls      polls.php 
    templates/view       view.php 
  Log:
  First optimization step reducing the number of queries and simplify query types:
  - use just one simple query in getPolls() as retrieving polls ID separated is not needed and choices are retrieved by getVotes()
  - track choice count on vote instead of having a join query to get the choices count
  - cannot find any usage of poll_results_to so remove it
  - use div and CSS insted of requesting the server for the pixel.php colored image
  - add a dedicated and cached get poll function (getPoll still is called when lisitng polls several times for every poll)
  - make getVotes() statis as we get them in the poll list then again later when chekig individual poll actions in isEditabe()
  - remove settings the group permission. poll_group was droped last year so the cast to set the group permission never occurs
  - use scry_voted cookie even to reduce DB access in hasVoted()
  
  Permissions
  - Avoid permission check overhead for common poll show/read task by do not set the permission of every poll as default permission on poll creation time. Create the default permission only when you actually pass to the permission editing form. Check the default permissions in the Scry::hasPermission function for non existing permissions.
  
  Demographics
  - Added demographics.php config file to define demographics groups
  - Added hook to detect user demographics group belonging
  - Add a drop down to which display between demographics groups in poll view
  
  Others changes:
  - spited read support in sql driver
  - template -> view
  - php5 constants and function definitions
  - replace deprecated is_a with interface of
  - autoload
  
  Revision  Changes    Path
  No                    (new)
  No                    (new)
  No                    (new)
  No                    (new)
  No                    (new)
  No                    (new)
  1.17      +8 -9      scry/conclude.php
  1.6       +2 -0      scry/config/.cvsignore
  1.16      +6 -4      scry/config/conf.xml
  1.1       +21 -0     scry/config/demographics.php.dist (new)
  1.1       +59 -0     scry/config/hooks.php.dist (new)
  1.31      +8 -9      scry/delete.php
  1.17      +0 -1      scry/docs/CHANGES
  1.5       +2 -1      scry/docs/CREDITS
  1.48      +8 -13     scry/edit.php
  1.4       +15 -10    scry/editperms.php
  1.32      +7 -10     scry/export.php
  1.59      +9 -19     scry/lib/Block/poll.php
  1.32      +8 -12     scry/lib/Block/summary.php
  1.42      +136 -57   scry/lib/Driver.php
  1.70      +234 -208  scry/lib/Driver/sql.php
  1.4       +3 -4      scry/lib/Forms/Vote.php
  1.72      +91 -73    scry/lib/Scry.php
  1.1       +27 -0     scry/lib/View.php (new)
  1.35      +22 -11    scry/lib/api.php
  1.40      +9 -13     scry/lib/base.php
  1.30      +124 -98   scry/po/scry.pot
  1.2       +129 -105  scry/po/sl_SI.po
  1.48      +17 -22    scry/polls.php
  1.5       +12 -2     scry/scripts/sql/scry.mssql.sql
  1.6       +12 -2     scry/scripts/sql/scry.sql
  1.1       +21 -0     scry/templates/block/summary.php (new)
  1.1       +3 -0      scry/templates/main/main.php (new)
  1.1       +36 -0     scry/templates/polls/polls.php (new)
  1.1       +70 -0     scry/templates/view/view.php (new)
  1.3       +7 -4      scry/themes/screen.css
  1.41      +29 -26    scry/view.php
  1.41      +8 -10     scry/vote.php

  Chora Links:
  http://cvs.horde.org/diff.php/?r1=.-1&r2=No&ty=u
  http://cvs.horde.org/diff.php/?r1=.-1&r2=No&ty=u
  http://cvs.horde.org/diff.php/?r1=.-1&r2=No&ty=u
  http://cvs.horde.org/diff.php/?r1=.-1&r2=No&ty=u
  http://cvs.horde.org/diff.php/?r1=.-1&r2=No&ty=u
  http://cvs.horde.org/diff.php/?r1=.-1&r2=No&ty=u
  http://cvs.horde.org/diff.php/scry/conclude.php?r1=1.16&r2=1.17&ty=u
  http://cvs.horde.org/diff.php/scry/config/.cvsignore?r1=1.5&r2=1.6&ty=u
  http://cvs.horde.org/diff.php/scry/config/conf.xml?r1=1.15&r2=1.16&ty=u
  http://cvs.horde.org/co.php/scry/config/demographics.php.dist?r=1.1
  http://cvs.horde.org/co.php/scry/config/hooks.php.dist?r=1.1
  http://cvs.horde.org/diff.php/scry/delete.php?r1=1.30&r2=1.31&ty=u
  http://cvs.horde.org/diff.php/scry/docs/CHANGES?r1=1.16&r2=1.17&ty=u
  http://cvs.horde.org/diff.php/scry/docs/CREDITS?r1=1.4&r2=1.5&ty=u
  http://cvs.horde.org/diff.php/scry/edit.php?r1=1.47&r2=1.48&ty=u
  http://cvs.horde.org/diff.php/scry/editperms.php?r1=1.3&r2=1.4&ty=u
  http://cvs.horde.org/diff.php/scry/export.php?r1=1.31&r2=1.32&ty=u
  http://cvs.horde.org/diff.php/scry/lib/Block/poll.php?r1=1.58&r2=1.59&ty=u
  http://cvs.horde.org/diff.php/scry/lib/Block/summary.php?r1=1.31&r2=1.32&ty=u
  http://cvs.horde.org/diff.php/scry/lib/Driver.php?r1=1.41&r2=1.42&ty=u
  http://cvs.horde.org/diff.php/scry/lib/Driver/sql.php?r1=1.69&r2=1.70&ty=u
  http://cvs.horde.org/diff.php/scry/lib/Forms/Vote.php?r1=1.3&r2=1.4&ty=u
  http://cvs.horde.org/diff.php/scry/lib/Scry.php?r1=1.71&r2=1.72&ty=u
  http://cvs.horde.org/co.php/scry/lib/View.php?r=1.1
  http://cvs.horde.org/diff.php/scry/lib/api.php?r1=1.34&r2=1.35&ty=u
  http://cvs.horde.org/diff.php/scry/lib/base.php?r1=1.39&r2=1.40&ty=u
  http://cvs.horde.org/diff.php/scry/po/scry.pot?r1=1.29&r2=1.30&ty=u
  http://cvs.horde.org/diff.php/scry/po/sl_SI.po?r1=1.1&r2=1.2&ty=u
  http://cvs.horde.org/diff.php/scry/polls.php?r1=1.47&r2=1.48&ty=u
  http://cvs.horde.org/diff.php/scry/scripts/sql/scry.mssql.sql?r1=1.4&r2=1.5&ty=u
  http://cvs.horde.org/diff.php/scry/scripts/sql/scry.sql?r1=1.5&r2=1.6&ty=u
  http://cvs.horde.org/co.php/scry/templates/block/summary.php?r=1.1
  http://cvs.horde.org/co.php/scry/templates/main/main.php?r=1.1
  http://cvs.horde.org/co.php/scry/templates/polls/polls.php?r=1.1
  http://cvs.horde.org/co.php/scry/templates/view/view.php?r=1.1
  http://cvs.horde.org/diff.php/scry/themes/screen.css?r1=1.2&r2=1.3&ty=u
  http://cvs.horde.org/diff.php/scry/view.php?r1=1.40&r2=1.41&ty=u
  http://cvs.horde.org/diff.php/scry/vote.php?r1=1.40&r2=1.41&ty=u