[cvs] commit: framework/Date Date.php framework/Date/tests strftime.phpt strftime_de.phpt

Jan Schneider jan at horde.org
Sat Nov 24 11:37:54 UTC 2007


Zitat von Chuck Hagenbuch <chuck at horde.org>:

> Quoting Jan Schneider <jan at horde.org>:
>
>>   It turns out that %r (time in a.m. and p.m. notation) returns
>> empty when using nl_langinfo() in locales that use 24-hour-times.
>> This makes more sense to me, but is still different from the
>> system's strftime() implemention, so should we drop it?
>
> I'm not sure why returning empty is ever expected for a time format? I
> might be missing something, but if a user turns off the twenty_four
> preference, shouldn't we show am/pm regardless of their locale?

We do, because we build the time string ourselves, and don't use %r.  
But your point makes sense, I'm gonna remove %r from the internally  
supported list then.

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/



More information about the cvs mailing list