[cvs] commit: genie/lib Driver.php Genie.php genie/lib/Driver sql.php

[Chuck Hagenbuch]

Quoting Duck <duck at obala.net>:

>   Log:
>   I doubt we will see any other driver than sql. So merge it with  
> main drievr class to not have a file just for the singleton/factory.
>   Don't store the items list in driver cache as is not used later,  
> just return them and save some memory usage.

In general, I agree, but we have always tried to maintain this pattern  
so that others can write new backends if they need to/want to.  
Especially if you're using an opcode cache the one extra file should  
make *very* little difference. So I'd prefer to see it kept as  
Genie_Driver_Sql. Alternately, we could port the whole thing to Rdo,  
which would have a much different set of requirements for having  
another backend, but would also get rid of the monolithic Driver object.

I think that'd be preferable honestly.

Also, we should be removing singletons wherever possible, especially  
if the factory pattern goes away.

-chuck