[cvs] commit: framework/Share/Share sql.php

[Jan Schneider]

Zitat von "Michael Rubinsky" <mike at theupstairsroom.com>:

> Quoting "Jan Schneider" <jan at horde.org>:
>
>> jan         2008-06-06 06:50:14 EDT
>>
>>  Modified files:
>>    Share/Share          sql.php
>>  Log:
>>  $data['perm'] is not set here, so don't try to unset it.
>
> ...and wouldn't it be possible for $data['perm'] to be set, but not  
> an  array in that block of code?  Not sure off hand if it ever  
> happens,  but I do remember a lot of trickiness with the $perms  
> array when  debugging this code...

Yes, but that's catched too. I have no idea which code paths end  
there, I was just fixing undefined index warning.
I'm happily leaving the semantic part for you. :)

Jan.

-- 
Do you need professional PHP or Horde consulting?
http://horde.org/consulting/