[dev] small change in message.php

Chuck Hagenbuch chuck@horde.org
Sat, 30 Dec 2000 23:13:33 -0500
Previous message: small change in message.php
Next message: [cvs] commit: hordeweb
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Quoting Atif Ghaffar <aghaffar@developer.ch>:

>  I have started to hack IMP again :) (Im back!) 

Welcome back!

>  I saw all the nice features in the CVS HEAD version. 
>  I like the filtering. I implemented it too, but on the server-side (Sieve,
>  but thats vendor-specific). 

I would be interested in offering a Sieve front-end if you'd be interested in 
contributing it.

>  Would it be possible to change it to 
>  $headers['From'] = get_barefrom();  # reuse code. 

Yup, makes sense. I've committed it.

>  Oh and a small remark for the function get_barefrom. 
>  line 730 in IMP.lib writes 
>  $_barefrom .= '@' . $imp['maildomain']; 
> 
>  which is not always the best thing. 
>  For example, I connect to mx23.4unet.net and it changes my From address to
> 
>  aghaffar@mx23.4unet.net for which there is no MX record and if someone
> replies 
>  to that address, some mail servers on the net gets confused for a while. 
> 
>  Possible solution: 
>  Since there is a $conf['server']['to_domain'] variable defined in 
>  imp/config/conf.php, it would be nice to check if the value exists there and
> 
>  append it instead of $imp['maildomain']. Also sometimes, $imp['maildomain']
> is 
>  just an internal address such as "localhost",
> "cyrus.internal.zurich.4unet.net" 
>  etc etc. 

... sounds like you're not using the $servers['<servername>']['from_host'] 
correctly. That will get put into $imp['maildomain'] if you set it.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"If you can't stand the heat, get out of the chicken!" - Baby Blues


>From chuck@horde.org Date: Tue,  2 Jan 2001 13:17:49 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 1207 invoked from network); 2 Jan 2001 18:18:40 -0000
Received: from r93aag000369.sbo-smr.ma.cable.rcn.com (HELO marina.horde.org) (209.6.192.126)
  by horde.org with SMTP; 2 Jan 2001 18:18:39 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 693223D10; Tue,  2 Jan 2001 13:17:49 -0500 (EST)
Received: from 206.243.191.252 ( [206.243.191.252])
	as user chuck@marina by marina.horde.org with HTTP;
	Tue,  2 Jan 2001 13:17:49 -0500
Message-ID: <978459469.3a521b4d5f5ae@marina.horde.org>
Date: Tue,  2 Jan 2001 13:17:49 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
References: <20010102180635.893.qmail@horde.org>
In-Reply-To: <20010102180635.893.qmail@horde.org>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.6-cvs
Subject: Re: [cvs] commit: imp compose.php

Quoting chuck@horde.org:

>   Log:
>   make the sae_sent_mail var regiseter_globals = Off compliant.

Uh, yeah. =) You know what I meant...

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"If you can't stand the heat, get out of the chicken!" - Baby Blues


>From anil@recoil.org Date: Tue,  2 Jan 2001 11:27:05 +0000
Return-Path: <anil@recoil.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 7553 invoked from network); 2 Jan 2001 20:00:34 -0000
Received: from brick.recoil.org (212.25.240.43)
  by horde.org with SMTP; 2 Jan 2001 20:00:34 -0000
Received: (qmail 11337 invoked from network); 2 Jan 2001 15:04:10 -0000
Received: from total.recoil.org (212.25.240.40)
  by brick.recoil.org with SMTP; 2 Jan 2001 15:04:10 -0000
Received: (qmail 2456 invoked by uid 99); 2 Jan 2001 11:27:05 -0000
Received: from m983-mp1-cvx1c.lis.ntl.com ( [m983-mp1-cvx1c.lis.ntl.com])
	as user avsm@localhost by horde.recoil.org with HTTP;
	Tue,  2 Jan 2001 11:27:05 +0000
Message-ID: <978434825.3a51bb09ce45e@horde.recoil.org>
Date: Tue,  2 Jan 2001 11:27:05 +0000
From: Anil Madhavapeddy <anil@recoil.org>
To: dev@lists.horde.org
References: <20010102044057.62502.qmail@horde.org>
In-Reply-To: <20010102044057.62502.qmail@horde.org>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.6-cvs
Subject: Re: [cvs] commit: horde problem.php horde/config ...

Quoting max@horde.org:

>   
>   I ran into a few stumbling blocks with the validator.  It
>   seems that you can't put <form>...</form> tags inside tables
>   unless the form is complete within one <td></td> tag.  In fact,
>   once you open a <table> tag you can't put anything else unless
>   its within the <td></td> pair (or <th></th> of course). This
>   would make compliancy and layout rather difficult to achieve
>   so if anyone has any brilliant ideas, do tell.
>   

I ran into exactly the same problem with WHUPS XHTML compliancy.
There's not a lot to be done about it, from what I could see,
so what I did was to embed a <table> within the <form>, rather than
the other way around.

-- 
Anil Madhavapeddy, <anil@recoil.org>


>From chuck@horde.org Date: Tue,  2 Jan 2001 15:33:05 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 10920 invoked from network); 2 Jan 2001 20:33:56 -0000
Received: from r93aag000369.sbo-smr.ma.cable.rcn.com (HELO marina.horde.org) (209.6.192.126)
  by horde.org with SMTP; 2 Jan 2001 20:33:56 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id BC1753D10; Tue,  2 Jan 2001 15:33:05 -0500 (EST)
Received: from 206.243.191.252 ( [206.243.191.252])
	as user chuck@marina by marina.horde.org with HTTP;
	Tue,  2 Jan 2001 15:33:05 -0500
Message-ID: <978467585.3a523b01b2390@marina.horde.org>
Date: Tue,  2 Jan 2001 15:33:05 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
References: <20010102044057.62502.qmail@horde.org>
In-Reply-To: <20010102044057.62502.qmail@horde.org>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.6-cvs
Subject: Re: [cvs] commit

Quoting max@horde.org:

>   -- xhtml 1.0 compliancy (not finished)

Good start, though - we're getting there.

>   -- docs/CODING_STANDARDS section 12

This is great! Thanks for doing this. I've just added the one minor tweak about 
nowrap, checked, selected, etc.

>   I ran into a few stumbling blocks with the validator.  It
>   seems that you can't put <form>...</form> tags inside tables
>   unless the form is complete within one <td></td> tag.  In fact,
>   once you open a <table> tag you can't put anything else unless
>   its within the <td></td> pair (or <th></th> of course). This
>   would make compliancy and layout rather difficult to achieve
>   so if anyone has any brilliant ideas, do tell.

It seems that if you start the <form> outside the <table>, all these issues go 
away.

>   Also I found out that php's url rewriter isn't compliant in
>   two respects.  The hidden input tag it adds is in ALL CAPS;
>   it is not terminated correctly: <input ...> instead of
>   <input ... />.  This along with "arg_seperator" being set to
>   '&' instead of '&amp;' would break compliancy.  I'm thinking
>   we should suggest disabling url_rewriter.tags php.ini setting
>   since we do our own session propogation.

I'm going to look at fixing these, though the arg_seperator bit I don't want to 
touch myself...

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"If you can't stand the heat, get out of the chicken!" - Baby Blues
Previous message: small change in message.php
Next message: [cvs] commit: hordeweb
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]