$conf['user']['allow_filters']

[Jon Parise]

On Sat, Mar 03, 2001 at 04:31:07PM -0500, Chuck Hagenbuch wrote:

> > I was thinking about retiring the $conf['user']['allow_filters']
> > option in favor of checking the "locked" flag on the 'filter's
> > preference, too.  Comments?
> 
> The only reason I can think to keep it is to let administrators
> define filters for their users that the users can't edit. But I'm
> not convinced that this is worth it.

Ah, good point.  If the administrator added some filtering rules to
the default filter's preference and then locked it, that would exhibit
the behavior you describe.  However, we would always have to check the
contents of the filter's preference to know whether to actually apply
them, which is probably the more correct behavior anyway.

I think $conf['user']['allow_filters'] is really just redundant for
$prefs->isLocked('filters').  At least, that's the way it appears to
be used in the code right now.

-- 
Jon Parise (jon@csh.rit.edu)  .  Rochester Inst. of Technology
http://www.csh.rit.edu/~jon/  :  Computer Science House Member


>From chuck@horde.org Date: Sat,  3 Mar 2001 16:40:40 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 22373 invoked from network); 3 Mar 2001 21:41:41 -0000
Received: from 208-59-178-62.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com (HELO marina.horde.org) (208.59.178.62)
  by horde.org with SMTP; 3 Mar 2001 21:41:41 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id F18943CA9; Sat,  3 Mar 2001 16:40:40 -0500 (EST)
Received: from 192.168.0.101 ( [192.168.0.101])
	as user chuck@marina.horde.org by marina.horde.org with HTTP;
	Sat,  3 Mar 2001 16:40:40 -0500
Message-ID: <983655640.3aa164d8d7465@marina.horde.org>
Date: Sat,  3 Mar 2001 16:40:40 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 2.3.7-cvs
Subject: Re: [dev] $conf['user']['allow_filters']

Quoting Jon Parise <jon@csh.rit.edu>:

> Ah, good point.  If the administrator added some filtering rules to
> the default filter's preference and then locked it, that would exhibit
> the behavior you describe.  However, we would always have to check the
> contents of the filter's preference to know whether to actually apply
> them, which is probably the more correct behavior anyway.

Good point.

> I think $conf['user']['allow_filters'] is really just redundant for
> $prefs->isLocked('filters').  At least, that's the way it appears to
> be used in the code right now.

Yeah, I say nuke it.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"We have no fuel on board, plus or minus 8 kilograms." -A NASA scientist