[dev] Fwd: [PHP-DEV] PHP 4.0.7

Cynic cynic@mail.cz
Wed, 08 Aug 2001 22:48:56 +0200


At 21:57 8/8/2001, Chuck Hagenbuch wrote the following:
-------------------------------------------------------------- 
>Quoting Cynic <cynic@mail.cz>:
>
>> I guess that depends on the required version of PHP. HTTP_*_VARS
>> will remain, as Zeev wrote. If you don't want to require 4.0.7+,
>> $_* should be banned.
>
>Well, we're going to need 4.0.7 for a stable release of PEAR, anyway...

Hm... I'd go with the new variables then. Why doing it the hard
way?

>> Another issue is error_reporting. Is the Horde family E_ALL clean?
>
>Yes.

I'm glad to hear this.

>> I guess it's not, since this is not mentioned in CODING_STANDARDS.
>> And I also think it should be.
>
>Someone want to put this in?

Is this ok? I can commit it.

Index: CODING_STANDARDS
===================================================================
RCS file: /cvs/horde/horde/docs/CODING_STANDARDS,v
retrieving revision 1.29
diff -u -b -r1.29 CODING_STANDARDS
--- CODING_STANDARDS    2001/05/09 22:22:51     1.29
+++ CODING_STANDARDS    2001/08/08 20:36:41
@@ -201,6 +201,10 @@
 $HTTP_GET_VARS, $HTTP_POST_VARS, $HTTP_COOKIE_VARS, $HTTP_SESSION_VARS,
 $HTTP_SERVER_VARS, and $HTTP_ENV_VARS to access all get, post, cookie,
 session, server, and environment data, respectively.
+
+All Horde code should work with error_reporting = E_ALL. Failure to do so would
+result in ugly output, error logs getting filled with lots of warning messages,
+or even downright broken scripts.

 All Horde code should work regardless of the setting of magic_quotes_gpc.
 Form data should be passed through Horde::dispelMagicQuotes(), which will




cynic@mail.cz
-------------
And the eyes of them both were opened and they saw that their files
were world readable and writable, so they chmoded 600 their files.
    - Book of Installation chapt 3 sec 7