[dev] Re: [cvs] cvs commit: imp login.php redirect.php horde/lib Lang.php

Jon Parise jon@horde.org
Thu, 3 Jan 2002 12:24:24 -0500


On Thu, Jan 03, 2002 at 06:15:39PM +0100, Jan Schneider wrote:

> > Could it be stored in the session instead of using another
> > cookie?
> 
> Yes, of course. Just didn't think of that.
 
Okay, I think that would probably be the best approach, then, and
it would further guarantee cookie-less operation.

The change could be made for IMP 3.1.

-- 
Jon Parise (jon@csh.rit.edu)  .  Information Technology (2001)
http://www.csh.rit.edu/~jon/  :  Computer Science House Member


>From chuck@horde.org Date: Thu,  3 Jan 2002 12:46:36 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 17430 invoked from network); 3 Jan 2002 17:47:15 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.196.127)
  by clark.horde.org with SMTP; 3 Jan 2002 17:47:15 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id A3CDE39B4; Thu,  3 Jan 2002 12:46:36 -0500 (EST)
Received: from 192.168.0.128 ( [192.168.0.128])
	as user chuck@localhost by marina.horde.org with HTTP;
	Thu,  3 Jan 2002 12:46:36 -0500
Message-ID: <1010079996.3c3498fc79604@marina.horde.org>
Date: Thu,  3 Jan 2002 12:46:36 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
References: <DJEILBHPPNCLMOPLANCHGEBFJPAA.samuel@gsw.com.br> <1010076761.3c348c59223dd@linux.wg.de> <20020103170325.GA22820@csh.rit.edu> <1010077911.3c3490d7950b6@marina.horde.org> <20020103171530.GD22820@csh.rit.edu>
In-Reply-To: <20020103171530.GD22820@csh.rit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
Subject: Re: [dev] Load Preferences

Quoting Jon Parise <jon@horde.org>:

> Does that mean that you'll be fixing that? =)

At _some_ point, yes. :)

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"What was and what may be, lie, like children whose faces we cannot see, in the
arms of silence. All we ever have is here, now." - Ursula K. Le Guin


>From chuck@horde.org Date: Thu,  3 Jan 2002 12:46:56 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 17618 invoked from network); 3 Jan 2002 17:47:34 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.196.127)
  by clark.horde.org with SMTP; 3 Jan 2002 17:47:34 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 3053E39FF; Thu,  3 Jan 2002 12:46:56 -0500 (EST)
Received: from 192.168.0.128 ( [192.168.0.128])
	as user chuck@localhost by marina.horde.org with HTTP;
	Thu,  3 Jan 2002 12:46:56 -0500
Message-ID: <1010080016.3c34991008fea@marina.horde.org>
Date: Thu,  3 Jan 2002 12:46:56 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
References: <20020102133328.E5893473@arkady.horde.org> <1010072698.3c347c7a12073@marina.horde.org> <1010073353.3c347f0983e5d@linux.wg.de> <1010074468.3c348364ebb99@marina.horde.org> <1010075963.3c34893b3f8c2@linux.wg.de> <20020103171156.GC22820@csh.rit.edu> <1010078139.3c3491bb86570@linux.wg.de>
In-Reply-To: <1010078139.3c3491bb86570@linux.wg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
Subject: Re: [dev] Re: [cvs] cvs commit: imp login.php redirect.php horde/lib Lang.php

Quoting Jan Schneider <jan@horde.org>:

> > Could it be stored in the session instead of using another
> > cookie?
> 
> Yes, of course. Just didn't think of that.

I think that would be preferable.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"What was and what may be, lie, like children whose faces we cannot see, in the
arms of silence. All we ever have is here, now." - Ursula K. Le Guin


>From jan@horde.org Date: Thu,  3 Jan 2002 19:42:40 +0100
Return-Path: <jan@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 19818 invoked from network); 3 Jan 2002 18:51:20 -0000
Received: from mailout05.sul.t-online.com (194.25.134.82)
  by clark.horde.org with SMTP; 3 Jan 2002 18:51:20 -0000
Received: from fwd11.sul.t-online.de 
	by mailout05.sul.t-online.de with smtp 
	id 16MCxJ-0008CX-02; Thu, 03 Jan 2002 19:51:09 +0100
Received: from linux.wg.de (320034214675-0001@[217.225.46.126]) by fmrl11.sul.t-online.com
	with esmtp id 16MCx3-2AOEwSC; Thu, 3 Jan 2002 19:50:53 +0100
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g03Igf918180
	for <dev@lists.horde.org>; Thu, 3 Jan 2002 19:42:41 +0100
Received: from 192.168.60.1 ( [192.168.60.1])
	as user jan@linux by linux.wg.de with HTTP;
	Thu,  3 Jan 2002 19:42:40 +0100
Message-ID: <1010083360.3c34a620ea6fd@linux.wg.de>
Date: Thu,  3 Jan 2002 19:42:40 +0100
From: Jan Schneider <jan@horde.org>
To: dev@lists.horde.org
References: <20020102133328.E5893473@arkady.horde.org> <20020102181304.GJ23942@csh.rit.edu>
In-Reply-To: <20020102181304.GJ23942@csh.rit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [dev] Re: [cvs] cvs commit: imp login.php redirect.php horde/lib Lang.php

Zitat von Jon Parise <jon@horde.org>:

> On Wed, Jan 02, 2002 at 05:33:28AM -0800, Jan Schneider wrote:
> 
> >   After login
> >   1) The user's preference
> >   2) The preference's default value
> >   3) The language selected on the login screen
> >   4) The browser's accept-language header
> >   5) The default value in $nls
>    
> Shouldn't 2 and 3 be switched, allowing the user to override the
> default?

Now that I thought about it a bit this would require too much modification 
in the preference backend. It's not worth it if you achieve the same goal 
by setting the default value empty.

Currently we can't determine if a preference is set by a user or the 
default value from prefs.php. But this would be necessary if we want to 
switch 2 and 3.

I think it's better to remove the default value for the language 
preferences in all applications' prefs.php.dist. We have a horde wide 
default value in lang.php anyway and selecting the language rather from the 
browser or the login screen than from the administrator's gusto definitely 
makes sense.

Jan.

::::::::::::::::::::::::::::::::::::::::
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::


>From jan@horde.org Date: Thu,  3 Jan 2002 19:54:56 +0100
Return-Path: <jan@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 20348 invoked from network); 3 Jan 2002 19:01:18 -0000
Received: from mailout05.sul.t-online.com (194.25.134.82)
  by clark.horde.org with SMTP; 3 Jan 2002 19:01:18 -0000
Received: from fwd00.sul.t-online.de 
	by mailout05.sul.t-online.de with smtp 
	id 16MD76-0005pb-05; Thu, 03 Jan 2002 20:01:16 +0100
Received: from linux.wg.de (320034214675-0001@[217.225.46.126]) by fmrl00.sul.t-online.com
	with esmtp id 16MD6y-0vjziyC; Thu, 3 Jan 2002 20:01:08 +0100
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g03Isv918288
	for <dev@lists.horde.org>; Thu, 3 Jan 2002 19:54:57 +0100
Received: from 192.168.60.1 ( [192.168.60.1])
	as user jan@linux by linux.wg.de with HTTP;
	Thu,  3 Jan 2002 19:54:56 +0100
Message-ID: <1010084096.3c34a900d476c@linux.wg.de>
Date: Thu,  3 Jan 2002 19:54:56 +0100
From: Jan Schneider <jan@horde.org>
To: dev@lists.horde.org
References: <20020103173703.8A10E492@arkady.horde.org>
In-Reply-To: <20020103173703.8A10E492@arkady.horde.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [cvs] cvs commit: turba/lib api.php

Zitat von Jan Schneider <jan@ammma.de>:

> jan         2002/01/03 09:37:03 PST
> 
>   Modified files:        (Branch: RELENG_1)
>     lib                  api.php 
>   Log:
>   MFH 1.19: search() returns a Turba_List object not an array. This
> prevents
>   adding addresses by the registry.
>   
>   Revision  Changes    Path
>   1.14.2.4  +2 -2      turba/lib/api.php

Good start, this bug is in the release version. :-(

Jan.

::::::::::::::::::::::::::::::::::::::::
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::


>From jan@horde.org Date: Thu,  3 Jan 2002 19:34:11 +0100
Return-Path: <jan@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 20701 invoked from network); 3 Jan 2002 19:02:05 -0000
Received: from mailout07.sul.t-online.com (194.25.134.83)
  by clark.horde.org with SMTP; 3 Jan 2002 19:02:05 -0000
Received: from fwd10.sul.t-online.de 
	by mailout07.sul.t-online.de with smtp 
	id 16MCna-0004n0-07; Thu, 03 Jan 2002 19:41:06 +0100
Received: from linux.wg.de (320034214675-0001@[217.225.46.126]) by fmrl10.sul.t-online.com
	with esmtp id 16MCnN-1Z3REuC; Thu, 3 Jan 2002 19:40:53 +0100
Received: from localhost (localhost [127.0.0.1])
	by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g03IYB918162
	for <dev@lists.horde.org>; Thu, 3 Jan 2002 19:34:11 +0100
Received: from 192.168.60.1 ( [192.168.60.1])
	as user jan@linux by linux.wg.de with HTTP;
	Thu,  3 Jan 2002 19:34:11 +0100
Message-ID: <1010082851.3c34a4234bbee@linux.wg.de>
Date: Thu,  3 Jan 2002 19:34:11 +0100
From: Jan Schneider <jan@horde.org>
To: dev@lists.horde.org
References: <20020102133328.E5893473@arkady.horde.org> <1010072698.3c347c7a12073@marina.horde.org> <1010073353.3c347f0983e5d@linux.wg.de> <1010074468.3c348364ebb99@marina.horde.org> <1010075963.3c34893b3f8c2@linux.wg.de> <20020103171156.GC22820@csh.rit.edu>
In-Reply-To: <20020103171156.GC22820@csh.rit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [dev] Re: [cvs] cvs commit: imp login.php redirect.php horde/lib Lang.php

Zitat von Jon Parise <jon@horde.org>:

> On Thu, Jan 03, 2002 at 05:39:23PM +0100, Jan Schneider wrote:
> 
> > Yes, we need to pass this value through all pages during a session, so
> that 
> > we can select this language in Lang::select() if appropriate. Otherwise
> it 
> > would get overriden by the browser language.
>  
> Could it be stored in the session instead of using another
> cookie?

Done.

Jan.

::::::::::::::::::::::::::::::::::::::::
AMMMa AG - discover your knowledge
:::::::::::::::::::::::::::
Detmolder Str. 25-33 :: D-33604 Bielefeld
fon +49.521.96878-0 :: fax  +49.521.96878-20
http://www.ammma.de
::::::::::::::::::::::::::::::::::::::::::::::