[cvs] cvs commit: horde/templates/maintenance confirm_top.inc

Jon Parise jon@horde.org
Sat, 2 Feb 2002 02:09:41 -0500


On Fri, Feb 01, 2002 at 10:52:16PM -0800, Max Kalika wrote:

> max         2002/02/01 22:52:16 PST
> 
>   Modified files:
>     templates/maintenance confirm_top.inc 
>   Log:
>   getName() -> getParam('name')
>   
>   if this will be MFH it needs to be getName() for Horde RELENG_1

Woops, that's what I get for not testing my commit.  In my
defense, I was in the middle of unbreaking the PHP autoconf stuff
under FreeBSD. =)

-- 
Jon Parise (jon@csh.rit.edu)  .  Information Technology (2001)
http://www.csh.rit.edu/~jon/  :  Computer Science House Member


>From kaalh@smol.org Date: Sat,  2 Feb 2002 13:05:25 +0100
Return-Path: <kaalh@smol.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 98074 invoked from network); 2 Feb 2002 12:05:27 -0000
Received: from ns1.prospecom.com (HELO mail.smol.org) (foobar@213.186.34.104)
  by clark.horde.org with SMTP; 2 Feb 2002 12:05:27 -0000
Received: (qmail-ldap/ctrl 27666 invoked by uid 3333); 2 Feb 2002 12:05:25 -0000
Received: from 193.251.85.154 ( [193.251.85.154])
	as user kaalh@smol.org@127.0.0.1 by smol.org with HTTP;
	Sat,  2 Feb 2002 13:05:25 +0100
Message-ID: <1012651525.3c5bd605ce373@smol.org>
Date: Sat,  2 Feb 2002 13:05:25 +0100
From: Kaalh! <kaalh@smol.org>
To: dev@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
Subject: IMP.php patch

Fix a bug which prevent messages handling from folders other than 'INBOX' 

-- 
Kaalh 

Index: IMP.php 
=================================================================== 
RCS file: /repository/imp/lib/IMP.php,v 
retrieving revision 1.213 
diff -u -r1.213 IMP.php 
--- IMP.php     2 Feb 2002 05:41:52 -0000       1.213 
+++ IMP.php     2 Feb 2002 11:57:32 -0000 
@@ -220,7 +220,7 @@ 
             $prefs->setValue('sortdir', $GLOBALS['HTTP_GET_VARS']
['sortdir']); 
         } 
         
-        $mailbox = Horde::getFormData('mailbox', 'INBOX'); 
+        $mailbox = Horde::getFormData('mailbox'); 
         if ($mailbox != null) { 
             $GLOBALS['imp']['mailbox'] = $mailbox; 
         } elseif (!isset($GLOBALS['imp']['mailbox'])) { 




>From andreas@dahlen.ws Date: Sat,  2 Feb 2002 14:05:20 +0100
Return-Path: <andreas@dahlen.ws>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 2345 invoked from network); 2 Feb 2002 13:05:51 -0000
Received: from as1-5-2.b.bonet.se (HELO tena.dahlen.ws) (194.236.143.39)
  by clark.horde.org with SMTP; 2 Feb 2002 13:05:51 -0000
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by tena.dahlen.ws (8.12.1/8.12.1) with ESMTP id g12D5l4k014144
	for <dev@lists.horde.org>; Sat, 2 Feb 2002 14:05:47 +0100
Received: from localhost (localhost.localdomain [127.0.0.1])
	by localhost.localdomain (AvMailGate-6.11.0.3) id 14137-1B0085B4;
	Sat, 02 Feb 2002 14:05:20 +0100
Received: from 10.0.1.100 ( [10.0.1.100])
	as user anj@localhost by www.dahlen.ws with HTTP;
	Sat,  2 Feb 2002 14:05:20 +0100
Message-ID: <1012655120.3c5be4102e645@www.dahlen.ws>
Date: Sat,  2 Feb 2002 14:05:20 +0100
From: =?ISO-8859-1?B?QW5kcmVhcyBEYWhs6W4=?= <andreas@dahlen.ws>
To: dev@lists.horde.org
References: <1012651525.3c5bd605ce373@smol.org>
In-Reply-To: <1012651525.3c5bd605ce373@smol.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
X-AntiVirus: OK (checked by AntiVir Version 6.10.0.34)
Subject: Re: [dev] IMP.php patch

Hi!

The parameter 'INBOX' is just a default value if the 
variable 'maildir' isn't set.  So I don't see why it should be 
romeved.

/Andreas

Citerar Kaalh! <kaalh@smol.org>:

> Fix a bug which prevent messages handling from folders other than
> 'INBOX' 
> 
> -- 
> Kaalh 
> 
> Index: IMP.php 
> ===================================================================
> 
> RCS file: /repository/imp/lib/IMP.php,v 
> retrieving revision 1.213 
> diff -u -r1.213 IMP.php 
> --- IMP.php     2 Feb 2002 05:41:52 -0000       1.213 
> +++ IMP.php     2 Feb 2002 11:57:32 -0000 
> @@ -220,7 +220,7 @@ 
>              $prefs->setValue('sortdir', $GLOBALS['HTTP_GET_VARS']
> ['sortdir']); 
>          } 
>          
> -        $mailbox = Horde::getFormData('mailbox', 'INBOX'); 
> +        $mailbox = Horde::getFormData('mailbox'); 
>          if ($mailbox != null) { 
>              $GLOBALS['imp']['mailbox'] = $mailbox; 
>          } elseif (!isset($GLOBALS['imp']['mailbox'])) { 
> 
> 
> 
> -- 
> Horde Developers mailing list: http://horde.org/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe@lists.horde.org
> 





>From chuck@horde.org Date: Sat,  2 Feb 2002 11:26:36 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 4856 invoked from network); 2 Feb 2002 16:27:15 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.196.127)
  by clark.horde.org with SMTP; 2 Feb 2002 16:27:15 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 514123C91; Sat,  2 Feb 2002 11:26:36 -0500 (EST)
Received: from 192.168.0.117 ( [192.168.0.117])
	as user chuck@localhost by marina.horde.org with HTTP;
	Sat,  2 Feb 2002 11:26:36 -0500
Message-ID: <1012667196.3c5c133c189f9@marina.horde.org>
Date: Sat,  2 Feb 2002 11:26:36 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
References: <1012651525.3c5bd605ce373@smol.org> <1012655120.3c5be4102e645@www.dahlen.ws>
In-Reply-To: <1012655120.3c5be4102e645@www.dahlen.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
Subject: Re: [dev] IMP.php patch

Quoting Andreas Dahlén <andreas@dahlen.ws>:

> The parameter 'INBOX' is just a default value if the 
> variable 'maildir' isn't set.  So I don't see why it should be 
> romeved.

The patch is correct.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"What was and what may be, lie, like children whose faces we cannot see, in the
arms of silence. All we ever have is here, now." - Ursula K. Le Guin