[dev] nic and whois

Mathieu Arnold arn_mat@club-internet.fr
Thu, 07 Mar 2002 20:46:37 +0100


--On jeudi 7 mars 2002 14:09 -0500 Chuck Hagenbuch <chuck@horde.org> wrote:

> Quoting Mathieu Arnold <arn_mat@club-internet.fr>:
>
>> http://www.absolight.fr/mat/diff.diff
>
> Please read Horde's CODING_STANDARDS; the ereg_replace you use here is
> completely unnecessary.

well, it works for me, if you want to edit it so that it fits your will, go 
on :)

>> http://www.absolight.fr/mat/whois.php
>
> This file is empty. Or perhaps parsed by your server?

http://www.absolight.fr/mat/whois.php.txt

-- 
Mathieu Arnold


>From chuck@horde.org Date: Thu,  7 Mar 2002 20:18:40 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 43060 invoked from network); 8 Mar 2002 01:19:19 -0000
Received: from h00104bc60b3c.ne.mediaone.net (HELO marina.horde.org) (24.91.196.127)
  by clark.horde.org with SMTP; 8 Mar 2002 01:19:19 -0000
Received: by marina.horde.org (Postfix, from userid 33)
	id 9DE7D39B0; Thu,  7 Mar 2002 20:18:40 -0500 (EST)
Received: from 192.168.0.117 ( [192.168.0.117])
	as user chuck@localhost by marina.horde.org with HTTP;
	Thu,  7 Mar 2002 20:18:40 -0500
Message-ID: <1015550320.3c8811707341c@marina.horde.org>
Date: Thu,  7 Mar 2002 20:18:40 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
References: <1015528146.3c87bad2b165f@marina.horde.org> <9761015.1015533996@sauron>
In-Reply-To: <9761015.1015533996@sauron>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
Subject: Re: [dev] nic and whois

Quoting Mathieu Arnold <arn_mat@club-internet.fr>:

> well, it works for me, if you want to edit it so that it fits your will, go 
> on :)

That's not the point. If you're going to submit patches, and you ignore the 
coding standards, you're making the developer's lives harder and making it much 
less likely that your patches will be rejected/ignored.

> http://www.absolight.fr/mat/whois.php.txt

Committed, thanks.

-chuck

--
Charles Hagenbuch, <chuck@horde.org>
"A dream which helps you to live your reality with dignity
 and justice is a good dream." - Tariq Ramadan