Chora 2.0 "view" link problem
Jean-Michel POURE
jm.poure@freesurf.fr
Thu, 4 Apr 2002 17:51:15 +0200
Dear all,
I am new to the list and installed latest Chora CVS version. Thank you all
for this great application.
I can view text files using Chora "view" link. But when trying to view an
HTML file, chora returns :
" Call to a member function on a non-object in [...]/horde/chora/co.php on
line 75 ". Can anyone reproduce the problem?
Cheers,
Jean-Michel
>From jan@horde.org Date: Thu, 4 Apr 2002 19:04:21 +0200
Return-Path: <jan@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 55054 invoked from network); 4 Apr 2002 17:10:34 -0000
Received: from mailout07.sul.t-online.com (194.25.134.83)
by clark.horde.org with SMTP; 4 Apr 2002 17:10:34 -0000
Received: from fwd03.sul.t-online.de
by mailout07.sul.t-online.com with smtp
id 16tAiZ-00031M-01; Thu, 04 Apr 2002 19:08:11 +0200
Received: from linux.wg.de (320034214675-0001@[217.88.135.229]) by fmrl03.sul.t-online.com
with esmtp id 16tAiI-1IwQYiC; Thu, 4 Apr 2002 19:07:54 +0200
Received: from localhost (localhost [127.0.0.1])
by linux.wg.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g34H4Mn22444
for <dev@lists.horde.org>; Thu, 4 Apr 2002 19:04:23 +0200
Received: from 192.168.60.158 ( [192.168.60.158])
as user jan@mail.wg.de by jan.dip.ammma.net with HTTP;
Thu, 4 Apr 2002 19:04:21 +0200
Message-ID: <1017939861.3cac8795cd5d8@jan.dip.ammma.net>
Date: Thu, 4 Apr 2002 19:04:21 +0200
From: Jan Schneider <jan@horde.org>
To: dev@lists.horde.org
References: <200203311349.g2VDnsv08597@lv.raad.tartu.ee>
In-Reply-To: <200203311349.g2VDnsv08597@lv.raad.tartu.ee>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 3.1-cvs
X-Sender: 320034214675-0001@t-dialin.net
Subject: Re: [dev] re-updated Estonian translations
Zitat von Toomas Aas <toomas.aas@raad.tartu.ee>:
> I've updated the Estonian translations of Horde, IMP and Turba. This
> time they are based on CVS HEAD checkout from March 30th.
Committed, thanks. Just note that there are a few untranslated strings left.
Jan.
--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft
>From akira@kurogane.net Date: Fri, 5 Apr 2002 03:07:04 +0900
Return-Path: <akira@kurogane.net>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 57257 invoked from network); 4 Apr 2002 18:12:14 -0000
Received: from unknown (HELO kurogane.net) (61.122.41.109)
by clark.horde.org with SMTP; 4 Apr 2002 18:12:14 -0000
Received: (from nobody@localhost)
by kurogane.net (8.9.3+3.2W/8.9.3) id DAA13098
for dev@lists.horde.org; Fri, 5 Apr 2002 03:07:04 +0900
X-Authentication-Warning: ns1.kurogane.net: nobody set sender to akira@kurogane.net using -f
Received: from 61.200.33.126 ( [61.200.33.126])
as user akira@localhost by www.kurogane.net with HTTP;
Fri, 5 Apr 2002 03:07:04 +0900
Message-ID: <1017943624.3cac9648d478e@www.kurogane.net>
Date: Fri, 5 Apr 2002 03:07:04 +0900
From: Akira Kurogane <akira@kurogane.net>
To: dev@lists.horde.org
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-MOQ10179436247cd033fb3d64b09c923c66ea6d41a6fd"
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
X-Originating-IP: 61.200.33.126
Subject: Patches for enabling japanese
---MOQ10179436247cd033fb3d64b09c923c66ea6d41a6fd
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Hello again everybody,
well, I didn't get any blow-back about requiring mbstring as php
configuration/installation option so I'll take that as an implicit "yes", you're
all happy to re-install your php modules asap.
Feel free to flame me right now ;-) But do it on the dev list so we can
get an idea of how many people it affects, so we can choose the right time do
this thing.
For the initial modifications, five files need patching (*.diff files attached).
These are
lib/MIME.php
lib/MIME/Part.php
imp/lib/IMP.php
imp/lib/MIME/Viewer/text.php
imp/compose.php
The reason Japanese need all these mods when other languages have so far been
mostly handled without language-specific additions is because of two reasons: 1)
Out of all the locales known to me Japanese is the only one that uses a
distinct, email-only encoding (iso-2022-jp, aka JIS). Conversion to and from
Shift-JIS or EUC (the operating system 'codepages') has always been required by
japanese email clients. Reason 2): iso-2022-jp is a 7bit encoding, which means
some of the charset detection used presently would mistake it for ascii. (eg.
$D$$$F!"%9%-%kE* )
Four of these files contain mbstring functions (mb_convert_encoding,
mb_preferred_mime_name, etc.) and hence will break those who aren't ready for
them. See http://www.php.net/manual/en/ref.mbstring.php for an explanation about
this extension module.
Yours,
Akira
-------------------------------------------------
>From Kurogane.net
---MOQ10179436247cd033fb3d64b09c923c66ea6d41a6fd--
>From akira@kurogane.net Date: Fri, 5 Apr 2002 03:13:54 +0900
Return-Path: <akira@kurogane.net>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 58521 invoked from network); 4 Apr 2002 18:19:06 -0000
Received: from unknown (HELO kurogane.net) (61.122.41.109)
by clark.horde.org with SMTP; 4 Apr 2002 18:19:06 -0000
Received: (from nobody@localhost)
by kurogane.net (8.9.3+3.2W/8.9.3) id DAA13111
for dev@lists.horde.org; Fri, 5 Apr 2002 03:13:54 +0900
X-Authentication-Warning: ns1.kurogane.net: nobody set sender to akira@kurogane.net using -f
Received: from 61.200.33.126 ( [61.200.33.126])
as user akira@localhost by www.kurogane.net with HTTP;
Fri, 5 Apr 2002 03:13:54 +0900
Message-ID: <1017944034.3cac97e29ec2f@www.kurogane.net>
Date: Fri, 5 Apr 2002 03:13:54 +0900
From: Akira Kurogane <akira@kurogane.net>
To: dev@lists.horde.org
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
X-Originating-IP: 61.200.33.126
Subject: Diffs for Japanese Localization
Ah, sorry, it seems that diffs weren't attached in that last email regarding
japanese modifications. Please see the included text if you're interested in them.
Akira
*****************The diffs for lib/MIME.php
67,77c67
< // ### AKIRA ###
< // iso-2022-jp (aka 'JIS') is, difficulty, a 7-bit encoding. Special detection
is needed.
< $jis_descriptor = 'iso-2022-jp'; // = mb_preferred_mime_name('JIS');
< if ($jis_descriptor =strtolower(@mb_preferred_mime_name(mb_detect_encoding($text)))) {
<
$charset = $jis_descriptor;
< if (((strlen($text) * 3) + strlen($charset) + 7) > 76) {
< $text = MIME::encode(substr($text, 0, (23 -
strlen($charset))), $charset) . MIME::encode(substr($text, (23 -
strlen($charset))), $charset, false);
< } else {
< $text = "=?$charset?B?" . strtr(trim(base64_encode($text)), '
', '_') . "?=\n\t";
< }
< } elseif (MIME::is8bit($text)) {
---
> if (MIME::is8bit($text)) {
213,216d202
<
< // ### AKIRA ###
< $jis_descriptor = 'iso-2022-jp'; // = mb_preferred_mime_name('JIS');
< if ($jis_descriptor == strtolower(@mb_preferred_mime_name($charset))) $decoded mb_convert_encoding($decoded, Lang::getCharset(), 'iso-2022-jp');
*****************The diffs for lib/MIME/Part.php
187,189d186
<
// ### AKIRA ###
<
if (strtolower($language) == 'ja_jp') $this->charset = 'iso-2022-jp';
< if (strtolower($language) == 'ja_jp') $this->transferEncoding '7bit';
*****************The diffs for imp/lib/MIME/Viewer/text.php
41,42c41
< // ### AKIRA ###
< if ('iso-2022-jp' !strtolower(@mb_preferred_mime_name($mime->charset))) $text htmlspecialchars($text, ENT_QUOTES, $charset); // htmlspecialchars can make a
dog's breakfast of iso-2022-jp
---
> $text = htmlspecialchars($text, ENT_QUOTES, $charset);
92,96c91
< // ### AKIRA ###
< if ('iso-2022-jp' == strtolower(@mb_preferred_mime_name($mime->charset))) {
<
$text = _("<p><i>this message was converted from iso-2022-jp</i></p>\n") . $text;
<
$text = IMP::decodeJIS($text);
< } elseif (strtolower($mime->charset) != strtolower(Lang::getCharset()) &&
---
> if (strtolower($mime->charset) != strtolower(Lang::getCharset()) &&
*****************The diffs for imp/lib/IMP.php
975,995d974
< // ### AKIRA ###
< /*
< * decode iso-2022-jp text into specified or automatically defined charset
< */
< function decodeJIS($text, $destCharset = null)
< {
< $jis_descriptor = 'iso-2022-jp'; // = mb_preferred_mime_name('JIS');
< $destCharset = @mb_preferred_mime_name($destCharset) ?
mb_preferred_mime_name($destCharset) : Lang::getCharset();
< return mb_convert_encoding($text, $destCharset, $jis_descriptor);
< }
<
< /*
< * encode text into iso-2022-jp from specified or automatically defined charset
< */
< function encodeJIS($text, $origCharset = null)
< {
< $jis_descriptor = 'iso-2022-jp'; // = mb_preferred_mime_name('JIS');
< $origCharset = @mb_preferred_mime_name($origCharset) ?
mb_preferred_mime_name($origCharset) : Lang::getCharset();
< return mb_convert_encoding($text, $jis_descriptor, $origCharset);
< }
< // ### AKIRA ### end
*****************The diffs for imp/compose.php
571,576c571
<
// ### AKIRA ###
< if ('ja_JP' == Lang::select()) {
< $msg = IMP::decodeJIS(findBody($attachments));
< } else {
< $msg .= findBody($attachments);
< }
---
> $msg = findBody($attachments);
641,646c636
< // ### AKIRA ###
< if ('ja_JP' == Lang::select()) {
< $msg .= IMP::decodeJIS(findBody($attachments));
< } else {
< $msg .= findBody($attachments);
< }
---
> $msg .= findBody($attachments);
736,743c726
< // ### AKIRA ###
< $jis_descriptor = 'iso-2022-jp'; // = mb_preferred_mime_name('JIS');
< if ('ja_JP' == Lang::select()) {
< $message = IMP::encodeJIS($message);
<
$body = new MIME_Part('text/plain', $message, $jis_descriptor);
< } else {
< $body = new MIME_Part('text/plain', $message);
< }
---
> $body = new MIME_Part('text/plain', $message);
750,753d732
<
// ### AKIRA ###
< if ('ja_JP' == Lang::select()) {
<
$trailer = IMP::encodeJIS($trailer);
<
}
809,813c788
< if ('ja_JP' == Lang::select()) {
<
$headers['Subject'] = IMP::encodeJIS($subject);
<
} else {
< $headers['Subject'] = $subject;
<
}
---
> $headers['Subject'] = $subject;
-------------------------------------------------
>From Kurogane.net
>From chuck@horde.org Date: Thu, 4 Apr 2002 13:38:42 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 59284 invoked from network); 4 Apr 2002 18:39:05 -0000
Received: from h00104bc60b3c.ne.client2.attbi.com (HELO marina.horde.org) (24.91.196.127)
by clark.horde.org with SMTP; 4 Apr 2002 18:39:05 -0000
Received: by marina.horde.org (Postfix, from userid 33)
id C7D9E3CAA; Thu, 4 Apr 2002 13:38:42 -0500 (EST)
Received: from 192.168.0.138 ( [192.168.0.138])
as user chuck@localhost by marina.horde.org with HTTP;
Thu, 4 Apr 2002 13:38:42 -0500
Message-ID: <1017945522.3cac9db29505d@marina.horde.org>
Date: Thu, 4 Apr 2002 13:38:42 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
References: <1017944034.3cac97e29ec2f@www.kurogane.net>
In-Reply-To: <1017944034.3cac97e29ec2f@www.kurogane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
Subject: Re: [dev] Diffs for Japanese Localization
Quoting Akira Kurogane <akira@kurogane.net>:
> Ah, sorry, it seems that diffs weren't attached in that last email
> regarding japanese modifications. Please see the included text if you're
> interested in them.
Jan, I'm leaving this up to you for now, since I don't know how it
intersects with your iconv work...
-chuck
--
Charles Hagenbuch, <chuck@horde.org>
"A dream which helps you to live your reality with dignity
and justice is a good dream." - Tariq Ramadan
>From chuck@horde.org Date: Thu, 4 Apr 2002 14:19:08 -0500
Return-Path: <chuck@horde.org>
Mailing-List: contact dev-help@lists.horde.org; run by ezmlm
Delivered-To: mailing list dev@lists.horde.org
Received: (qmail 62637 invoked from network); 4 Apr 2002 19:19:31 -0000
Received: from h00104bc60b3c.ne.client2.attbi.com (HELO marina.horde.org) (24.91.196.127)
by clark.horde.org with SMTP; 4 Apr 2002 19:19:31 -0000
Received: by marina.horde.org (Postfix, from userid 33)
id 50DF13C8E; Thu, 4 Apr 2002 14:19:08 -0500 (EST)
Received: from 192.168.0.138 ( [192.168.0.138])
as user chuck@localhost by marina.horde.org with HTTP;
Thu, 4 Apr 2002 14:19:08 -0500
Message-ID: <1017947948.3caca72c2503f@marina.horde.org>
Date: Thu, 4 Apr 2002 14:19:08 -0500
From: Chuck Hagenbuch <chuck@horde.org>
To: dev@lists.horde.org
References: <1017258514.3ca22212a02b9@imp.riboflavin.net>
In-Reply-To: <1017258514.3ca22212a02b9@imp.riboflavin.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
Subject: Re: [dev] imp "empty trash" modifications
Quoting "Marcus I. Ryan" <marcus@riboflavin.net>:
> If use_trash is set, this adds an icon to the IMP menu for emptying the
> trash (with cofirmation). It also makes the Hide Deleted | Purge
> Deleted disappear in the mailbox view. It maintains the "Empty Trash
> folder" view if you are in your trash folder. Since they are now
> mutually exclusive I removed the seperating pipe. NOTE: I got the
> trashcan icon from Chuck (empty_trash.gif).
Added to HEAD (along with the icon).
-chuck
--
Charles Hagenbuch, <chuck@horde.org>
"A dream which helps you to live your reality with dignity
and justice is a good dream." - Tariq Ramadan