[dev] Re: [cvs] cvs commit: imp/lib Folder.php

[Jan Schneider]

Zitat von Chuck Hagenbuch <chuck@horde.org>:

> Quoting Jan Schneider <jan@ammma.de>:
> 
> >   Log:
> >   We never htmlencoded the folder labels. If I miss something obvious
> >   here shout at me.
> 
> We encode them upon output in many places, and that's the proper place to
> 
> do it, so I guess that this change will cause problems where things get 
> encoded twice...
> 
> Even if we weren't, we should be encoding _as_ we output - think of
> future 
> cases where we might not be generating html - and not here.

Then we'll have to revamp even more, because flistselect() already returns 
partly html entities, I only encoded the parts that weren't already.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft