[dev] Re: [cvs] commit: imp compose.php mailbox.php

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz@bigworm.colorado.edu>:

> Quoting Chuck Hagenbuch <chuck@horde.org>:
> 
> | Quoting Michael M Slusarz <slusarz@bigworm.colorado.edu>:
> | 
> | >   Log:
> | >   Make sure the correct mailbox is loaded in the IMAP stream in 
> | > compose.php to ensure message headers can be obtained. Previously, 
> | > compose links from search results would not work because no mailbox
> was
> | > loaded.
> | 
> | Not so sure about the changes to compose.php - IMP::authenticate()
> should 
> | take care of operating on the $thismailbox parameter...
> 
> The problem is that the search results page was setting 'thismailbox' 
> to '**search'.  When a compose window was opened from the search results,
> compose was attempting to open the index in the '**search' mailbox which,
> obviously, didn't exists.  Since it is impossible to change 
> the 'thismailbox' parameter when created a compose link, I went the other
> route instead (changing the 'mailbox' parameter to the correct Mailbox of
> the message returned in the search list).

That's wrong. 'mailbox' has been '**search', but 'thismailbox' has correctly
been the folder name in the search results.
 
> any better solutions would be great but this method works without
> breaking 
> anything, i think, and it fixes the aforementioned problem with search 
> results.
> 
> BTW, on my TODO list is consolidating all header code into a class 
> (IMP_Header or something of that ilk).

That's great.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft