[dev] Re: [cvs] commit: imp folders.php

Eric Rostetter eric.rostetter@physics.utexas.edu
Tue, 4 Jun 2002 10:18:41 -0500


Quoting Jon Parise <jon@horde.org>:

> On Mon, Jun 03, 2002 at 02:22:59PM -0700, Chuck Hagenbuch wrote:
>
> (isset($check->Nmsgs) && $check->Nmsgs > 0)
> 
> ... could also be rewritten as ...
> 
> (!empty($check->Nmsgs))
> 
> I think that's a little more readable, considering the nature of the
> test.

Then how come in (e.g.) ./templates/common-header.inc we have code like:

if (!empty($refresh_time) && ($refresh_time > 0)
 
Isn't that then redundent?

-- 
Eric Rostetter
The Department of Physics
The University of Texas at Austin

"TAD (Technology Attachment Disorder) is an unshakable, impractical devotion
to a brand, platform, product line, or programming language. It's relatively
harmless among the rank and file, but when management is afflicted the damage
can be measured in dollars. It's also contagious -- someone with sufficient
political clout can infect an entire organization."

--"Enterprise Strategies" columnist Tom Yager.