[dev] Re: [cvs] commit: horde/lib Text.php

[Jan Schneider]

Zitat von Michael M Slusarz <slusarz@bigworm.colorado.edu>:

> slusarz     2002/12/19 12:00:56 PST
> 
>   Modified files:
>     lib                  Text.php
>   Log:
>   Check for invalid character set in toHTML() - this was where Horde was
>   crashing when an invalid character set was used in a message in IMP.
> Namely,
>   the preg_replace() function was crashing because the htmlspecialchars()
> call
>   in its paramater list was returning a warning.

As checkCharst() calls htmlspecialchars() anyway, wouldn't it make sense to
return the result so it doesn't have to called twice anywhere we use it.
It should move to Horde:: then, perhaps as Horde::specialChars() and taking
the quote style as an extra argument.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft