[dev] rtrim/Horde::removeParameter

Marko marko at oblo.com
Sun Dec 29 02:23:22 PST 2002


anyone know why we have htmlentities in this line at the end of Horde::url()
        return ($full ? $url : htmlentities($url));

it's messing up the Horde::removeParameter() - when the parameter removed is the
last parameter in a url, then the rtrim($url, '&?') will not match the & because
it is infact & after the htmlentities.

it's not so much of a problem except for esthetics, and when a parameter is
added after one is removed, which happens to be the last in the url, then weird
urls are created: ?show_active=1&show_new=1&&actionID=201 (note the double &)

but then the rtrim($url, '&?') is not exactly much use if someone has setup
different arg separators... MikeNZ :)

m.


More information about the dev mailing list