[dev] Category_sql bug / patch
Chuck Hagenbuch
chuck at horde.org
Tue Jan 14 16:03:14 PST 2003
Quoting Hans Lellelid <hans at appliedsec.com>:
> Also, -- more on Category framework. Shouldn't the _nameMap[$id] always
> map to the fullname of the category? Currently when a new category is
> created only the deepest element is stored in the _nameMap[] array. (on
> subsequent reloads the full cat name is stored in the array). Fixing
> this means that the line I sent the patch for previously (i.e. last line
> of Category_sql::addCategory()), should probably read:
>
> return parent::_addCategory($fullname, $id, $pid, $order) ? $id : false;
>
> (i.e. _addCategory($fullname...) and NOT _addCategory($name...) )
>
> Does that make sense?
Yup - committed, thanks!
-chuck
--
Charles Hagenbuch, <chuck at horde.org>
must ... find ... acorns ... *thud*
More information about the dev
mailing list