[dev] Re: [cvs] commit: horde/lib/iCalendar vevent.php

[Jan Schneider]

Zitat von Mike Cochrane <mike at graftonhall.co.nz>:

> > ----- Message from jan at horde.org ---------
> >
> > Zitat von Chuck Hagenbuch <chuck at horde.org>:
> >
> > > Quoting Mike Cochrane <mike at graftonhall.co.nz>:
> > >
> > > >   Log:
> > > >   Add toKronolithHash() to convert the vEvent to a Kronolith event
> > > hash.
> > >
> > > This *really* belongs in Kronolith, not in Horde.
> >
> > No, we have these methods in the Data classes already. But it should be
> > named toHash() then.
> >
> > Jan.
> 
> I think Kronolith_Event should have a fromvEvent() eventually. This would
> save a
> iCalender_vEvent::toHash() then a Kronoltih_Event::fromHash(), and do
> away with
> the intermediate representation.

I don't think so. The Data framework uses the toHash() during the import
routines so they can't be in an application's library. And to keep things
consistent, all toHash() methods should be in Horde libraries where possible.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft