[dev] Re: [cvs] commit: horde/lib Category.php horde/lib/Category sql.php

[Chuck Hagenbuch]

Quoting Marko Djukic <tech at oblo.com>:

>   Log:
>   the problem was deeper than just the typo, renameCategory seemed to
> have lost touch with reality - fix that the not exist/duplicate checking
> works in the cached array, and that it is updated once the category is
> renamed, fix that the sql actually finds the correct category to rename.

This really screws with the semantics for renameCategory(). It now expects
an id and a name... The second parameter has to be a name, but if it's going
to expect an id for the first, it should be a renameCategoryById(), and we
really should provide the by name version, also. And renameCategoryById()
has no reason to accept a CategoryObject object, as this version does...

-chuck

--
Charles Hagenbuch, <chuck at horde.org>
must ... find ... acorns ... *thud*