[dev] Re: General Linking/Relationship/Reference

Jeroen Huinink j.huinink at wanadoo.nl
Mon Feb 17 20:21:34 PST 2003


"Chuck Hagenbuch" <chuck at horde.org> wrote:
> Quoting j.huinink at wanadoo.nl:
>
> > I consider this a prototype, but fit for inclusion into HEAD, if you
like
> > the idea at all.  I'll hear your opinions and feedback.
>
> This looks pretty cool, and I'd love to commit it once it's cleaned up a
bit
> - there are a bunch of style problems I noticed at a quick glance, stuff
> like foreach( without a space, comment blocks for functions not starting
> with /**, files missing $Horde: $ tags, and at least a few of the files
had
> DOS line endings. I'd prefer it if these were cleaned up before the
initial
> commit, to save work/unnecessary changes going forward.
>
> Nice work!

After rereading my own statement I was not sure how it would be interpreted.
I didn't mean to say that this was ready for submission into HEAD, I just
felt that the code was stable enough. I'll go through the files and sent a
new patch.

Regards,
Jeroen





More information about the dev mailing list