[dev] Re: [cvs] commit: imp/lib IMP.php

[Jan Schneider]

Zitat von Eric Rostetter <eric.rostetter at physics.utexas.edu>:

> Quoting Mike Cochrane <mike at graftonhall.co.nz>:
> 
> > mikec       2003/02/16 18:36:07 PST
> >
> >   Modified files:
> >     lib                  IMP.php
> >   Log:
> >   save a strlen call
> >
> >   Revision  Changes    Path
> >   1.367     +4 -4      imp/lib/IMP.php
> >
> >   Chora Links:
> >   http://cvs.horde.org/diff.php/imp/lib/IMP.php?r1=1.366&r2=1.367&ty=u
> 
> Is the optimization here worth the loss of clarity (ease to read)? Or
> am I the only one who finds this more difficult to read?

I have no opinion about this certain patch, but I agree that we shouldn't
"over"-optimize the code. It doesn't matter if a function is called 10 or 20
times (if it isn't a syscall or an external binary).

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft