[dev] Re: [cvs] commit: luxor/lib/Driver sql.php luxor/lib Tagger.php

[Jan Schneider]

Zitat von Mike Cochrane <mike at graftonhall.co.nz>:

> > ----- Message from jan at horde.org ---------
> > > > Do you have further plans on fileId() and createFileId() that I
> don't
> > > see
> > > > currently? Wasn't fileId()'s purpose to always return a file's id
> if
> > > one
> > > > exists yet or not? Now we always have to check if a file has an id
> > > already
> > > > while it used to create one automagically before your change.
> > > >
> > > > Jan.
> > >
> > > Yeah, it was but calling getFiletime() every time we wanted a fileid
> > > seemed like
> > > a lot of overkill, not we only called it when we need it.
> > >
> > > getFiletime() will have a larger overhead when a cvs backend it being
> > > used and
> > > it's not the HEAD tag we're dealing with.
> >
> > Yes, I understand your intentions, but that still doesn't explain why
> this
> > can't be done in fileId().
> >
> > Jan.
> 
> I guess, pass the $files object reference to fileId()?

No, the $files object is globally available anyway.

I'd rather add lastModified() methods to Luxor_Files and Luxor_Driver that
can be used to compare modification times. A Luxor_Files::wasModified()
method can do this comparison. We can then easily skip indexing/referencing
a file if (!$files->wasModified($file)).

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft