[dev] Agora Fixes

Jon Wood jon at jellybob.co.uk
Wed Apr 2 12:46:30 PST 2003


On Wed, 2003-04-02 at 13:31, Jan Schneider wrote:
> Quoting Jon Wood <jon at jellybob.co.uk>:
> 
> > On Wed, 2003-04-02 at 13:21, Jan Schneider wrote:
> > > Quoting Jon Wood <jon at jellybob.co.uk>:
> > >
> > > > On Tue, 2003-04-01 at 22:56, Jeff Clark wrote:
> > > > > Fixes some form creation stuff.
> > > > > -
> > > > > Jeff Clark
> > > > Why the change from _forums->export from _forums->get?
> > >
> > > Because import is a reserverd word in ZendEngine 2.
> > What's wrong with just leaving it as get? (Sorry, that was a typo, the
> > patch changes all _forums->get calls to _forums->export, which just
> > seems a bit pointless.
> 
> I lost you here. What was in the code, what is now in the code and what
> changed it?
> And how do you think it needs to be fixed (along with a patch perhaps)?
> 
Sorry... I'll start again from the beggining.

I orginally replied to a post on the dev list, that included a patch for
Agora, which allegedly "Fixes some form creatation stuff", but also
changed all the $this->_forums->get calls to $this_forums->export in
Agora.php, ManageMessage.php, and ManageForums.php.

Having tried the patch more thoroughly now, I also found out that the
forum creation form doesn't work at all (doesn't even display, due to
more non-existant function calls) once it's patched.

Jon

> Jan.
> 
> --
> http://www.horde.org - The Horde Project
> http://www.ammma.de - discover your knowledge
> http://www.tip4all.de - Deine private Tippgemeinschaft



More information about the dev mailing list