[dev] Re: [Q] Horde Popups

[Marko Djukic]

if you use: Horde::addScriptFile('open_popup_win.js');
Horde handles all the including of the js file, the file is not "inlined", but
linked to and Horde makes sure you are not including the same file several
times.
plus i find it's easier to use...

marko

Quoting Johny <horde at agotnes.com>:

> Marko,
>
> Not sure if it'd work? I was working in imp/message.php, and this is
> what the other includes looked like;
>
> @@ -620,6 +678,7 @@
>   }
>   if ($browser->hasFeature('javascript')) {
>       require IMP_TEMPLATES . '/message/javascript.inc';
> +    require IMP_TEMPLATES . '/javascript/open_popup_win.js';
>
> I just noticed however that there is a call 10 lines up from this;
>
>   if ($browser->hasFeature('javascript')) {
>          include IMP_TEMPLATES . '/javascript/open_print_win.js';
>
> and I have to admit having no idea what the difference between a
> 'require' and an 'include' is, so the latter might work the same way in
> IMP... I'll investigate and see what seems more appropriate.
>
> I've mailed my patch to the Turba list, it's against the latest released
> versions rather than the CVS version. If it turns out to be useful I'm
> happy to update it against the latest and re-submit for inclusion.
>
> :)J
>
> Marko Djukic wrote:
> > Quoting Johny <horde at agotnes.com>:
> >



> >
> >>Marko,
> >>
> >>The popup works a  treat (once I figured to include it with
> >><DEFANGED_script/>
> >
> > use instead the function Horde::addScriptFile('open_popup_win.js');
> >
> > marko
> >
>
>
>
> --
> Horde developers mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe at lists.horde.org
>