[dev] Chora double escaping

John Morrissey jwm at horde.net
Tue Jun 10 06:38:05 PDT 2003


It looks like recent changes to Chora cause a double escaping of PATH_INFO -
Chora::url() urlescape()s it before passing to Horde::applicationUrl(),
which itself passes the URL through htmlentities().

Is the attached the correct way to fix it? I'm not quite sure what the
intent of the urlescape() in Chora::url() was.

john
-- 
John Morrissey          _o            /\         ----  __o
jwm at horde.net        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__
-------------- next part --------------
Index: chora/lib/Chora.php
===================================================================
RCS file: /repository/chora/lib/Chora.php,v
retrieving revision 1.40
diff -u -u -r1.40 Chora.php
--- chora/lib/Chora.php	9 Jun 2003 00:57:59 -0000	1.40
+++ chora/lib/Chora.php	10 Jun 2003 13:30:21 -0000
@@ -310,7 +310,7 @@
         $script = $script . '.php';
 
         if ($conf['options']['use_path_info']) {
-            $script .= '/' . urlencode($uri);
+            $script .= '/' . $uri;
         } else {
             $arglist['f'] = $uri;
         }


More information about the dev mailing list