[dev] Re: [cvs] commit: imp mailbox.php imp/lib Mailbox.php Message.php

[Jan Schneider]

Zitat von Jon Parise <jon at horde.org>:

> On Mon, Jun 16, 2003 at 09:24:21PM -0400, Chuck Hagenbuch wrote:
>
> > Sure. I was just making the point that it can be a *lot* harder to
> follow
> > the code now. Feel free to go with other ways that use fewer constants.
>
> I like the idea of using string-based action identifiers.  I doubt the
> string comparisons will be that expensive, and it would help
> readability quite a bit.  I never much cared for the numbers.

A problem is though, that typos are much harder to find with string actions.
If you have a typo in a constant name, you will notice immediately.
OTOH are action identifiers only used in prominent places anyway and thus
typos get spotted much easier than typos in variable names.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft