[dev] Re: WG: 2 weitergeleitete Nachrichten

[Nuno Loureiro]

On Wed, 2003-07-02 at 21:00, W. Tasin wrote:

> There's no special reason... I left it only because AFAICS you can 
> obtain some other information with imap_headerinfo() [newsgroup,  
> followup, ...] which could be of future interest for fetching (e.g. 
> don't fetch mail from newsgroups or similar).
> That's why I didn't touch it.

Right now and in a near future it's not needed, so I just remove both
calls and kept only your imap_fetch_overview(). If we need it later
we'll do the necessary changes then.

> I also thought about the issue "Why is it necessary to fetch all mail 
> headers? Wouldn't it be better to take the complete header only if it is 
> already decided that the mail is up to be fetched?"

Right. Going to move it to the method you did.

> But I left it for the same reason as above. It could be also possible to 
> interpret the header e.g. for the funcionality not fetching mails with 
> an X-Color entry (remarked as unseen).

The purpose of the X-color stuff is to mark mails fetched with a
specified color, so theorically when you are fetching you don't have a
x-color header. So imap_fetchheader() can be moved to your method.

> After sending the patch I also recognized that a default value of 
> 4000000 isn't a good idea it should be lower, because IIRC the default 
> value of memory_limit inside php.ini was 8M. I guess the memory 
> consumption on fetching a mail with almost 4M  is more than 8 M.

What value do you think it'd be ok for the default?

Thanks.

Nuno

> >
> >     I did some tests and everything seems okay.
> >
> >     Please don't forget to give him credits for the patch.
> >
> >
> >Thanks,
> >
> >  Nuno Loureiro
> >    
> >  
> >
> Ciao
> 
> Walter
> 
> PS: I guess the mail won't arrive to dev at lists.horde.org, because I'm 
> not subscribed... so feel free to forward the message to the developers 
> list.
-- 
Nuno Loureiro <nuno at co.sapo.pt>
PTM.com - http://www.sapo.pt/
PGP fingerprint = 8A32 5174 E80C 2D40 9075 405E C107 6592 054A 4D05