[dev] [PATCH] passwd sql & socket parameter

[Jan Schneider]

Zitat von Rob Lineweaver <rlineweaver at harrisonburg.k12.va.us>:

> Quoting Chuck Hagenbuch <chuck at horde.org>:
>
> > This is a bug in your configuration, not a bug in the driver.
>
> True.  But if that's your answer then I don't understand the purpose of
> the five
> existing lines seen in the patch.  They import the site's Horde config
> values
> for all the other DB params (if not explicitly overridden in this
> backend), so
> why should 'socket' be left out?  I would guess that 95% of the time a
> site
> administrator is going to use the same method to connect to the database
> for
> all the Horde apps, so why require them to always specify 'socket' in
> this
> backend config?  I could leave out any of the other  parameters and it
> wouldn't
> be a "bug" in my configuration because it would pull it from my main
> Horde sql
> config.

You are right. But an even more appropriate patch was one that uses
Horde::getDriverConfig() like all the other sql drivers (should).

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft