[dev] Fwd: horde/lib/Data.php

[Chuck Hagenbuch]

----- Forwarded message from lembke at lcc.ch -----
    Date: Tue, 19 Aug 2003 14:39:36 +0200
    From: Dietmar Lembke <lembke at lcc.ch>
Reply-To: Dietmar Lembke <lembke at lcc.ch>
 Subject: horde/lib/Data.php
      To: chuck at horde.org

Hi Chuck,

sorry for writing directly to you. Could not get into bug track!

I probably found a bug im horde/lib/Data.php which caused some problem
importing tsv data from a windows client. The original result with the
un patched version was  that you got a double line count when importing
MS-DOS text files. Since the lines where splited into an array on \n &
\r but should actually only split on \r\n. By reversing regex as below
the problem should be fixed.

Hope you can use it.

Best regards,
didi


--------------diff -rcs Data.php Data.php-orig------------------------
*** Data.php    Tue Aug 19 14:19:41 2003
--- Data.php-orig       Tue Aug 19 14:12:09 2003
***************
*** 372,378 ****
               return false;
           }

!         $contents = preg_split( "/(\r\n|\n|\r)/", rtrim(fread($fp,
filesize($filename))));

           fclose($fp);

--- 372,378 ----
               return false;
           }

!         $contents = preg_split( "/(\n|\r|\r\n)/", rtrim(fread($fp,
filesize($filename))));

           fclose($fp);
-------------end -diff -rcs Data.php
Data.php-orig------------------------


Lembke Computer Consulting GmbH
Dietmar Lembke
Rämslistrasse 94
CH-6315 Oberägeri
Tel: +41417508952

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: PGP 8.0 (Build 288) Beta

mQGiBD2p1+0RBAD7nsCLBGzGJ0hHv6JbWdTMC/n8kW4A2+W3R0QDryp+JAzmQHoE
T3umg6GC/TvSmT7Qs3Vc9SIzUGFsj5pZshwqTJxZ8Ch6VTMtUP+oBmREVmQeezNc
u+0KMtGeOB34bwVog7TAL7NaMomFM1VNghVfG6VcdBCG95TJ9NAn3QFzowCg/9xl
4g7bWP7zyjVFdf4TDnUaCAUEAKfOIcKI48pBGlAIyg6J+bvTiPuoxArkmxrMl+yt
2pcR/mqNmdZrPzvXakDOKsVnJ45qblmDe918/zalTYj5uZ2FajyFgT/t5nnICPui
nl7T1yO/glxKXHnyk3bGYS4w2TWuFHGr0/5SVHX8O+DoVxPf00/rVK7nXsCamoNa
RhMoA/wNxHJepxt700PK33CROlecPkbNGircqX/AYcqXQ+93RXKV2ppepzz0q/W7
BO9Z+chyffGXEJ+3/t+nhc4wtGr23IOvgIqPJUb+2Fhm2y7dZh9K+wwqQN/I2Py5
wlVK6/F/m9I0ylX4bUuxIEwcPZiwkcY5MHj9mcd6HlemGpKF57QfRGlldG1hciBM
ZW1ia2UgPGxlbWJrZUBsY2NjLmNoPokAWAQQEQIAGAUCPanX7QgLCQgHAwIBCgIZ
AQUbAwAAAAAKCRDmW3Bl0ifotIB0AKCzZRveTVGQwIOD2Zl6kGMcCAYlJwCdHJDO
8FL7xQMEAND5VU0/5xVtOPC5Ag0EPanX7RAIAPZCV7cIfwgXcqK61qlC8wXo+VMR
OU+28W65Szgg2gGnVqMU6Y9AVfPQB8bLQ6mUrfdMZIZJ+AyDvWXpF9Sh01D49Vlf
3HZSTz09jdvOmeFXklnN/biudE/F/Ha8g8VHMGHOfMlm/xX5u/2RXscBqtNbno2g
pXI61Brwv0YAWCvl9Ij9WE5J280gtJ3kkQc2azNsOA1FHQ98iLMcfFstjvbzySPA
Q/ClWxiNjrtVjLhdONM0/XwXV0OjHRhs3jMhLLUq/zzhsSlAGBGNfISnCnLWhsQD
GcgHKXrKlQzZlp+r0ApQmwJG0wg9ZqRdQZ+cfL2JSyIZJrqrol7DVekyCzsAAgIH
/0kM4y9yoxUFWVEbGDiPjCOZGR4q57H/LWYVqM7oYyf9rb8UkNVPixNNYVHd8soj
a05Xjjde6jY72bkJBo89WP1XETBtShoJrlmBlrhdgm/6fVqxwWCUc2sIPd25k4hB
AbYP0LCe887dVcg4U1aqV+OYplCGDdnD6tTMig1BCsLwu65u4xXXi3nvfrRvMK4p
VtNBA2Vxp41v+FG/yNaf8nBc/MQ5pSBDMlc+rzhhwyXOOpfiG0pWRBQiiHKVSSE5
LnBIbEGuzsk0Ku5PkqzZv1qCMQouOL0RjVWIeK9ri07737ZosFI8sVXwFnzTcEB0
XWaIPGbdx5K+u8sRFEkUF8+JAEwEGBECAAwFAj2p1+0FGwwAAAAACgkQ5ltwZdIn
6LQYkwCg3/gN4hj1LDOeDqIMfKohmq3V6oIAn1C7mDb6URXhO+Tls80VWvqMjalt
=C0Cp
-----END PGP PUBLIC KEY BLOCK-----



----- End forwarded message -----


-chuck

--
Charles Hagenbuch, <chuck at horde.org>
They're just looking at a wall of meat.