[dev] Re: [cvs] commit: horde/lib Form.php

[Chuck Hagenbuch]

Quoting Marko Djukic <tech at oblo.com>:

>   Log:
>   split up the isSubmitted() into submit() as well for checking the final
> submit, whilst isSubmitted() is now purely for checking before a final submit
> if a submit has been sent

This is confusing.

submit() implies performing an action, not checking a status. And isSubmitted()
implies just that, not an intermediate state. I think that submit() should go
back to isSubmitted(), and isSubmitted() should be named something else -
hasChanged(), perhaps.

-chuck

--
Charles Hagenbuch, <chuck at horde.org>
They're just looking at a wall of meat.