[dev] hordeauth imp bug

[Vijay Mahrra]

Hi Tim,

On Sat, Sep 06, 2003 at 08:30:27PM +0200, Tim Gorter saved a few trees
by typing:
: Even though logged into horde, but not authenticated to IMP, you get
: error:
: Warning: Invalid argument supplied for foreach() in
/usr/local/etc/httpd/vhosts/horde-cvs/imp/lib/Block/summary.php on
line 93

I believe that this is a result of the error you described following.
 
: Next, with 'Should we show list of servers..' set to hidden,
following
: errors appear:
: Notice: Undefined index: backend in
/usr/local/etc/httpd/vhosts/horde-cvs/imp/templates/login/login.inc on
line 186
: 
: Notice: Undefined variable: server in
/usr/local/etc/httpd/vhosts/horde-cvs/imp/templates/login/login.inc on
line 189

Sorry, this is a mistake in my code for the hordeauth patch, and 
those lines aren't actually needed (the entire block of code for that
If statement) , I'd left them there by mistake when originally working

from from the code in Gollem.  I've supplied a diff which removes
them.

Also a mistake was in my last patch for redirect.php.inc, I set $ptr
BEFORE the array_key_exists check rather than after.  Oops.

: only when 'Should we show list of servers..' is set to shown. And
one
: selects the server, does it login cleanly for me.

Still this leaves a problem of automatically logging in if hordeauth
is used with no server list - going to the IMP initial page requests
the username and password when it should, just log in a.  The code as
I wrote it doesn't support this just yet, but I will look to make a
further patch soon.

Apologies all around, please bear with me while I am learning how to
contribute to Horde.

Vijay
-------------- next part --------------
Index: login.inc
===================================================================
RCS file: /repository/imp/templates/login/login.inc,v
retrieving revision 2.132
diff -u -r2.132 login.inc
--- login.inc	3 Sep 2003 00:48:24 -0000	2.132
+++ login.inc	8 Sep 2003 09:08:35 -0000
@@ -179,20 +179,7 @@
       <?php echo $hordeauth_servers_list ?>
     </select><input type="button" class="button" onclick="imp_reload();" value="<?php echo _("Login") ?>" />
   </td>
-<?php elseif ($conf['server']['server_list'] == 'hidden'): ?>
-<tr>
-  <td colspan="2" align="center" class="smallheader">
-<?php
-if ($conf['backend']['change_server']) {
-    printf(_("Defaulted to: %s"), $server[$server_key]['name']);
-} else {
-    printf(_("Connect to: %s"), $server[$server_key]['name']);
-}
-?><br/><br/>
-  </td>
 </tr>
-<?php endif; ?>
-
 <?php if ($conf['server']['server_list'] == 'hidden'): ?>
 <tr>
     <td colspan="2"><input type="hidden" name="server" value="<?php echo $server_key ?>" /></td>
-------------- next part --------------
Index: redirect.php
===================================================================
RCS file: /repository/imp/redirect.php,v
retrieving revision 1.84
diff -u -r1.84 redirect.php
--- redirect.php	5 Sep 2003 10:17:30 -0000	1.84
+++ redirect.php	8 Sep 2003 09:09:55 -0000
@@ -82,8 +82,8 @@
         /* Read the required server parameters from the servers.php file */
         require_once IMP_BASE . '/config/servers.php';
         $server_key = Horde::getFormData('server_key');
-        $ptr = &$servers[$server_key];
             if (array_key_exists($server_key, $servers)) {
+                $ptr = &$servers[$server_key];
                 $server     = $ptr['server'];
                 $realm      = $ptr['realm'];
                 $port       = $ptr['port'];