[dev] javascript.php patch

Jason Rust jrust at rustyparts.com
Tue Oct 21 10:52:49 PDT 2003


When testing our kronolith on IE mac today I found that it was taking
several minutes for the page to load.  It turned out that the
session_start() call in the Registry constructor was causing the hang.
I think IE mac must not close it's requests to its src files correctly
causing the lock that PHP gives the session file to sit until a timeout.
Anyhow, I found that this can be fixed by telling javascript.php not to
start the session.  No session variables are used in the javascript.php
file that I could find, so I just changed the session flag to
HORDE_SESSION_NONE.  This should also have the added benefit of speeding
up page loads a bit.

-Jason
-------------- next part --------------
Index: javascript.php
===================================================================
RCS file: /repository/horde/services/javascript.php,v
retrieving revision 1.20
diff -u -r1.20 javascript.php
--- javascript.php      3 Oct 2003 16:07:06 -0000       1.20
+++ javascript.php      21 Oct 2003 17:41:04 -0000
@@ -14,7 +14,7 @@
 require_once HORDE_BASE . '/lib/Browser.php';

 $browser = &Browser::singleton();
-$registry = &Registry::singleton(HORDE_SESSION_READONLY);
+$registry = &Registry::singleton(HORDE_SESSION_NONE);

 // Figure out if we've been inlined, or called directly.
 $send_headers = strstr($_SERVER['PHP_SELF'], 'javascript.php');


More information about the dev mailing list