[dev] Minor patch to imp/templates/identities/manage.inc to change some fields width

Etienne Goyer etienne.goyer at linuxquebec.com
Mon Nov 10 11:36:41 PST 2003


Hi,

I had a user complain that the width of the "From" and "Return" was too
small.  He use something along the line "Jonathan Smoelevisky
<jonathan.schomelevsky at someservice.someplace.com>" that is too big to
fit in the current 40 caracters limit.  I made these field maxlength to 
120, and make the widget the same width as "Optionnal address" textarea 
for aesthetic reason.

Was there a reason for the limited width of the first four field of this
template ?  If not, it might even be a good idea to drop the maxlength
entirely ... 

Thanks !

-- 
Etienne Goyer                    Linux Québec Technologies Inc.
http://www.LinuxQuebec.com       etienne.goyer at linuxquebec.com
-------------- next part --------------
--- manage.inc.orig	Mon Nov 10 14:22:03 2003
+++ manage.inc	Mon Nov 10 14:27:27 2003
@@ -49,7 +49,7 @@
             <input type="hidden" name="edit_identity" value="<?php echo isset($to_edit) ? $to_edit : '' ?>" />
 <?php if (!$prefs->isLocked('default_identity')): ?>
             <?php echo Horde::label('id', _("Identity's name:")) ?><br />
-            <input name="id" id="id" size="30" maxlength="60" class="fixed" <?php echo isset($to_edit) ? 'value="' . $identity->getValue('id', $to_edit) . '" ' : '' ?>/>
+            <input name="id" id="id" size="40" maxlength="120" class="fixed" <?php echo isset($to_edit) ? 'value="' . $identity->getValue('id', $to_edit) . '" ' : '' ?>/>
 <?php else: ?>
             <input type="hidden" name="id" <?php if (isset($to_edit)) echo 'value="' . $identity->getValue('id', $to_edit) . '" '; ?>/>
 <?php endif; ?>
@@ -57,17 +57,17 @@
 
 <?php if (!$prefs->isLocked('fullname')): ?>
             <?php echo Horde::label('fullname', _("Your full name:")) ?><br />
-            <input name="fullname" id="fullname" size="30" maxlength="60" class="fixed" <?php if (isset($to_edit)) echo 'value="' . $identity->getValue('fullname', $to_edit) . '" '; ?>/><br />
+            <input name="fullname" id="fullname" size="40" maxlength="120" class="fixed" <?php if (isset($to_edit)) echo 'value="' . $identity->getValue('fullname', $to_edit) . '" '; ?>/><br />
 <?php endif; ?>
 
 <?php if (!$prefs->isLocked('from_addr')): ?>
             <?php echo Horde::label('from_addr', _("Your From: address:")) ?><br />
-            <input name="from_addr" id="from_addr" size="30" maxlength="60" class="fixed" <?php if (isset($to_edit)) echo 'value="' . $identity->getValue('from_addr', $to_edit) . '" '; ?>/><br />
+            <input name="from_addr" id="from_addr" size="40" maxlength="120" class="fixed" <?php if (isset($to_edit)) echo 'value="' . $identity->getValue('from_addr', $to_edit) . '" '; ?>/><br />
 <?php endif; ?>
 
 <?php if (!$prefs->isLocked('replyto_addr')): ?>
             <?php echo Horde::label('replyto_addr', _("Your Reply-to: address: <i>(optional)</i>")) ?><br />
-            <input name="replyto_addr" id="replyto_addr" size="30" maxlength="60" class="fixed" <?php if (isset($to_edit)) echo 'value="' . $identity->getValue('replyto_addr', $to_edit) . '" '; ?>/><br />
+            <input name="replyto_addr" id="replyto_addr" size="40" maxlength="120" class="fixed" <?php if (isset($to_edit)) echo 'value="' . $identity->getValue('replyto_addr', $to_edit) . '" '; ?>/><br />
 <?php endif; ?>
 
 <?php if (!$prefs->isLocked('alias_addr')): ?>


More information about the dev mailing list