[dev] Re: [cvs] commit: imp folders.php

Michael M Slusarz slusarz at bigworm.colorado.edu
Wed Dec 31 13:08:44 PST 2003


Quoting Chuck Hagenbuch <chuck at horde.org>:

| Quoting Jon Parise <jon at horde.org>:
|
| > I'd prefer that either $subscribe and $showAll were both passed in as
| > parameters or _initializeTree() referenced both of them as globals.
|
| I agree, FWIW. I'd prefer having both passed in as parameters.

Beat you to it - I don't know why I ever made $subscribe a global (ack ack - bad
programming) but I changed it back a few days ago and made the commit a few
minutes ago.

Another note - I am pretty close to converting folders.php to use Horde_Tree
(the whole reason I am cleaning up/preparing this code in the first place) so
watch for that soon.  I still have to work on some UI tweaks since the
Horde_Tree rendering code seems pretty set on the way it wants to output the
tree table, even though it makes the folder list like terrible,

michael

______________________________________________
Michael Slusarz [slusarz at bigworm.colorado.edu]
The University of Colorado at Boulder


More information about the dev mailing list