[dev] [turba] abstract setObject() method in Driver.php

[Michael Rubinsky]

Thanks Jan. While we're on the subject, should the abstract function 
definition for makeKey() be put back in Driver.php as well?  It seems to 
have disappeared from Driver.php since 1.2.2 release.  I know it's only a 
'stub' but I think it would be clearer to anyone writing a new driver that 
the method should be present.

Just my .02

Thanks!

Index: lib/Driver.php
===================================================================
RCS file: /repository/turba/lib/Driver.php,v
retrieving revision 1.41
diff -r1.41 Driver.php
120a121,134
>      * Create an object key for a new object.
>      *
>      * @abstract
>      * @param array $attributes  The attributes (in driver keys) of the
>      *                           object being added.
>      *
>      * @return string  A unique ID for the new object.
>      */
>     function makeKey($attributes)
>     {
>
>     }
>
>     /**


Zitat von Jan Schneider <jan at horde.org>:

> The method in Driver.php is an abstract method. If you look at the
> concrete
> implementations in the different drivers you'll see that they all use the
> three parameters.
> I fixed the signature of the abstract method to include all parameters
> too.
>
> Jan.
>