[dev] [turba] abstract setObject() method in Driver.php

[Michael Rubinsky]

Patch attached.

Thanks!


--On Thursday, January 22, 2004 4:02 AM -0800 dev-request at lists.horde.org 
wrote:

> Date: Thu, 22 Jan 2004 13:02:12 +0100
> From: Jan Schneider <jan at horde.org>
> Subject: Re: [dev] [turba] abstract setObject() method in Driver.php
> To: dev at lists.horde.org
> Message-ID: <20040122130212.1u5wcwwkskko8kw8 at neo.wg.de>
> Content-Type: text/plain; charset="ISO-8859-15"; format="flowed"
>
> Zitat von Michael Rubinsky <mike at theupstairsroom.com>:
>
>> Thanks Jan. While we're on the subject, should the abstract function
>> definition for makeKey() be put back in Driver.php as well?  It seems to
>> have disappeared from Driver.php since 1.2.2 release.  I know it's only a
>> 'stub' but I think it would be clearer to anyone writing a new driver
>> that the method should be present.
>
> In a not so strict language like PHP this is a matter of taste, but I
> personally agree for exactly the reason you said. Will you send a patch to
> add that stub?
>
> Jan.
-------------- next part --------------
Index: lib/Driver.php
===================================================================
RCS file: /repository/turba/lib/Driver.php,v
retrieving revision 1.41
diff -r1.41 Driver.php
120a121,134
>      * Create an object key for a new object.
>      *
>      * @abstract
>      * @param array $attributes  The attributes (in driver keys) of the
>      *                           object being added.
>      *
>      * @return string  A unique ID for the new object.
>      */
>     function makeKey($attributes)
>     {
>         
>     }
> 
>     /**