[dev] New IMSP classes in horde framework and turba

Michael Rubinsky mike at theupstairsroom.com
Sun Feb 8 16:25:01 PST 2004


Thanks for the feedback, Chuck.  I'll start taking care of the cleanup 
tasks also.  I wrote the code awhile ago, as part of my own web-mail type 
application so I know I've got to get it up to Horde's CS...

Thanks!
Mike

--On Thursday, February 05, 2004 8:55 PM -0800 dev-request at lists.horde.org 
wrote:

> Quoting Michael Rubinsky <mike at theupstairsroom.com>:
>
>> I've put together an initial tar-ball of code for the Net_IMSP classes in
>> framework/.  It consists of the new files in the framework directory
>> (framework/IMSP), a new driver for Turba, a patch for
>> turba/config/sources.php.dist and a patch for horde/config/prefs.php to
>> add an alternate login for the imsp server.
>
> This is committed - thanks! However, you need to take a read through
> horde/docs/CODING_STANDARDS, and fix the code for a number of things in
> there (indenting, spacing, etc). "receieve" was also misspelled in
> IMSP.php; I fixed that, but that'll probably trigger problems where's
> used in other files. Finally, the file organization was a bit off - I
> sorted them into the Net_IMSP package the way they should be, and the
> paths will need to be updated for that now.
>
> Thanks!
>
> -chuck







More information about the dev mailing list