[dev] Fetchmail problems...

[Marc Jauvin]

The included patch fixes the problem. If there is any good reason for the
rtrim() call, please let me know.

--marc

Marc Jauvin <marc at register4less.com> wrote:

> When using the fetchmail functionality from CVS HEAD, I get the 
> following error
> after the "@imap_append()" call from _addMessage() in 
> 'imp/lib/Fetchmail.php':
>
>   "Message contains invalid header"
>
> When I remove the 'rtrim($header)' call in _processMailMessage(), the problem
> disappears...
>
> Any suggestions on how to fix this?
>
> P.S. I am using Cyrus IMAP V2.1.15
>
> --
> Marc Jauvin
> http://register4less.com
> 450-441-5458
> --
> Horde developers mailing list - Join the hunt: http://horde.org/bounties/
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: dev-unsubscribe at lists.horde.org



--
Marc Jauvin
http://register4less.com
450-441-5458

-------------- next part --------------
Index: Fetchmail.php
===================================================================
RCS file: /repository/imp/lib/Fetchmail.php,v
retrieving revision 1.36
diff -u -r1.36 Fetchmail.php
--- Fetchmail.php       14 Feb 2004 08:37:46 -0000      1.36
+++ Fetchmail.php       27 Feb 2004 20:56:29 -0000
@@ -219,7 +219,7 @@
      */
     function _processMailMessage($header, $body)
     {
-        $msg = rtrim($header);
+        $msg = $header;

         if (empty($this->_params['acctcolor'])) {
             $msg .= "\nX-color: " . $this->_params['acctcolor'];
@@ -304,6 +304,8 @@
                 $GLOBALS['notification']->push(_("Fetchmail: ") . $res->getMessage(), 'horde.warning');
             } elseif ($res) {
                 $GLOBALS['notification']->push(_("Fetchmail: ") . sprintf(_("Fetched %d message(s) from %s"), $res, $fm_account->getValue('id', $val)), 'horde.success');
+            } else {
+                $GLOBALS['notification']->push(_("Fetchmail: no new messages."), 'horde.success');
             }
         }
     }