[dev] IMP Compose Null To:

[John Morrissey]

On Fri, Mar 19, 2004 at 07:07:00PM -0500, AJ wrote:
>   Just noticed something that may be silly, but I thought I'd bring it 
> up.  If you don't specify a recipient(To: filed) on the IMP compose 
> screen, you get a rather long error, see below.  Would it be better to 
> raise a more friendly error like, A recipient is required or something 
> along those lines?  Just a thought.
[snip]
> Unable to decode message event: 
[snip]

I can reproduce this; it looks like Notification_Listener::getEvent()
doesn't like it when it gets a PEAR_Error object from the message stack. Is
it ok if it accepts PEAR_Error as well?

--- /var/www/www.horde.net/horde/framework/Notification/Notification/Listener.php	2004-03-16 16:15:30.846770000 -0500
+++ Listener.php	2004-03-21 12:33:27.885943000 -0500
@@ -108,7 +108,7 @@
 
         // If we've failed to create a valid Notification_Event object
         // (or subclass object) so far, return a PEAR_Error.
-        if (!is_a($ob, 'Notification_Event')) {
+        if (!is_a($ob, 'Notification_Event') && !is_a($ob, 'PEAR_Error')) {
             $ob = PEAR::raiseError('Unable to decode message event: ' . $message['event']);
         }
 

john
-- 
John Morrissey          _o            /\         ----  __o
jwm at horde.net        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__