[dev] Re: [cvs] commit: framework/MIME/MIME Viewer.php

[Jan Schneider]

Zitat von Johan FISCHER <linux at fischaz.com>:

> Quoting John Morrissey <jwm at horde.net>:
>
>> jwm         2004/03/21 07:23:40 PST
>>
>>   Modified files:
>>     MIME/MIME            Viewer.php
>>   Log:
>>   fix some php5 warnings:
>>   - getDriver is called staticly, check for $this
>>   - if _getIcon() returns null, don't try to access object members from
>>   its return value
>>
>>   Revision  Changes    Path
>>   1.57      +9 -4      framework/MIME/MIME/Viewer.php
>>
>>   Chora Links:
>>   
>> http://cvs.horde.org/diff.php/framework/MIME/MIME/Viewer.php?r1=1.56&r2=1.57&ty=u
>>
>> --
>> To unsubscribe, mail: cvs-unsubscribe at lists.horde.org
>
>
> Fix the _getIcon method when the application doesn't have the icon for a
> mime-type hoping horde has it.
> The test should work with PHP5 (keep the isset($ob) part and also protect
> against infinite loop when even horde doesn't have the icon.

Committed, thanks.

> I'm not sure about the indentation and the typo of the elseif structure
> but the
> logic should be good. (Work with Chora in which the source files icons
> disappeared.

Compare it with what I committed to see how to match the coding standards.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - Neue Wege des Lernens
http://www.tip4all.de - Deine private Tippgemeinschaft