[dev] Horde :: Remember Username patch for Login

Jan Schneider jan at horde.org
Sat Apr 24 01:41:21 PDT 2004


Zitat von Joel Vandal <jvandal at infoteck.qc.ca>:

> Hi,
>
> I hope this time the patch will be ok :D
>
>> I'm really not sure if I want to see such a functionality in Horde but I
>> know that people will love it, and if Horde is only used for a forum or
>> some such it makes sense.
>
>> A few comments though:
>> - It MUST be configurable, that is being turned off in the configuration
>
> Configurable ? I've move all to preference so an user can set if they want
> to remember user or both user and pass.

No, I meant configurable. It should be in the administrators hands if they
want to allow these features. And it should default to off.
I am not sure if it makes sense to have this as a preference at all. Because
most of the "magic" happens even before the user logs in.

I think the admin should configure the level of what gets remembered and the
user should only have the possibility to turn this feature and off again on
the login screen.

>> - It should be a "remember me" feature, that is not only remembering the
>> user and/or password, but automatically log the user in with these
>> credentials.
>
> Also add a preference if the user want to automatically sign up.
> When a user have set to "remember both user/pass" or "Auto Signup" and click
> on "Logout", the password will be cleared.

See above.

>> - Please provide patches as unified diffs.
>
> Ok :) cvs diff -u ...

Better. :-)

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - Neue Wege des Lernens
http://www.tip4all.de - Deine private Tippgemeinschaft


More information about the dev mailing list