[dev] [imp-patch] invalid date headers

[Chuck Hagenbuch]

Quoting Francois Marier <francois at nit.ca>:

> Has this patch been committed ?  If not, are there any other changes I
> should make or are you simply not interested in fixing this minor bug
> that way ?

It has not. I would change a few things about it stylistically, but none of
those are keeping me from committing it. Basically, I don't consider 
this a bug
- a nicety when dealing with broken messages, definitely, but not a bug - and
I'm waffling about whether or not it's worth it to loop through the overviews
and do the strtotime() calls in order to check this.

So, I'm not trying to be difficult, but since you asked if there were other
changes you should make ...

What if, instead of changing Mailbox.php, instead, at the time of
display/fetching for display of the broken date header, at that point you
created an IMP_Headers object to get the Retrieved header, and guessed 
the date
from that. AND, for the big bonus, cached that Headers object somewhere 
so that
when/if the user views that message, the headers are already parsed and
fetched.

That way there'd be no impact at all on non-broken messages, and even a 
bit of a
performance boost to boot.

-chuck

--
"Regard my poor demoralized mule!" - Juan Valdez