[dev] [Fwd: [cvs] commit: framework/Data/* framework/iCalendar/*

[Chuck Hagenbuch]

Quoting Karsten Fourmont <fourmont at gmx.de>:

> It required quite a few changes to the applications themself, so I hope
> I didn't break anything. I tested it with importing and exporting
> from/to nag,mnemo,kronolith, and turba, displaying of vcard attachments
> in imp and sending invitations for events with kronolith.

I'll poke around and test as I can, but help from others here would be great.

> As a start I added a charset parameter to iCalendar.php's parsevCalendar
> function. This sould be used like this:
>
> a) Imp (or the mime attachment viewers) should set this parameter
> according to the attachment's charset info.
> b) manual Export/Import of Data should have charset selector combos.
>
> I'll look into it.

Sounds good.

> parsevCalendar in iCalendar.php now looks like this:
>
> -    function parsevCalendar($text, $base = 'VCALENDAR', $clear = true)
> +    function parsevCalendar($text, $base = 'VCALENDAR', $charset =
> 'utf-8', $clear = true)
>
> I did not find any places where the $clear parameter is explicitly
> specified, so I put charset before clear.

Seems fine, thanks for checking.

> There are still things to do (liker proper distinctions between 2.1 and
> 3.0 formats during export) but I wanted to make a start as the patch
> already grew way too  big (diffs are ~3000 lines).

Looks like a great start - go Karsten! :)

-chuck

--
"Regard my poor demoralized mule!" - Juan Valdez