[dev] help/options links
Roel Gloudemans
roel at gloudemans.info
Tue Aug 31 00:33:35 PDT 2004
> Whew indeed. I've cleaned this up and committed it - thanks! Let me know what
> you think of what I changed.
I see you moved both getServiceLink and showService to the Horde class. For
getServiceLink this is an excellent place. I have doubts about
showService. Its
sole purpose is to parse a configuration parameter. If I has to search for the
method, I'd go looking in Prefs. But I think this is just a matter of taste,
because the next place I'd look is the Horde class.
You even cleaned up the Help class something more. (nice) When I was modifying
the _usejs to usejs I was thinking that there should be a better method, but
was too lazy to go and search for it. ;)
I see that one patch didn't make it; the patch for services/prefs.php.
The patch
disallows the prefs from being set (next to not showing the link). Any
particular reason? (Just curious)
--- snip -----
--- prefs.php.org 2004-08-29 12:30:32.000000000 +0200
+++ prefs.php 2004-08-29 12:30:41.000000000 +0200
@@ -47,6 +47,10 @@
require_once $appbase . '/lib/prefs.php';
}
+if (!Horde::showService('options')) {
+ Horde::fatal('Forbidden.', __FILE__, __LINE__);
+}
+
if ($group == 'identities') {
if (isset($horde_members)) {
$prefGroups['identities']['members'] = array_merge($horde_members,
$prefGroups['identities']['members']);
----- snip -----
I'm not done yet on the menus. I'm somewhat of a security freak (professional
deformation) and don't like the mysql/php/command shell in the admin menu. One
of the reasons is that I have certificate based ssh access for just me and
password based access for the Horde users. The shells destroy what I gain by
using certificates on SSH.
I have to think of a way to turn them off (in an elegant way), with no way to
turn them on from the Horde interface.
Cheers,
(and thanks, for you opened a lot of sourcefiles too)
Roel.
More information about the dev
mailing list